Date: Sat, 16 Sep 2023 06:51:53 +0900 From: Tatsuki Makino <tatsuki_makino@hotmail.com> To: "freebsd-ports@FreeBSD.org" <freebsd-ports@freebsd.org> Subject: Re: www/chromium: 117.0.5938.62 build failed in 12.4-STABLE Message-ID: <SI2PR01MB50363579B8F2F38B36A851F9FAF6A@SI2PR01MB5036.apcprd01.prod.exchangelabs.com> In-Reply-To: <SI2PR01MB5036E736D08CC8D365F9EB5DFAF6A@SI2PR01MB5036.apcprd01.prod.exchangelabs.com> References: <SI2PR01MB5036E736D08CC8D365F9EB5DFAF6A@SI2PR01MB5036.apcprd01.prod.exchangelabs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Tatsuki Makino wrote on 2023/09/15 12:27:
> -#elif BUILDFLAG(IS_POSIX) && !BUILDFLAG(IS_FREEBSD)
> +#elif BUILDFLAG(IS_POSIX) && __FreeBSD__ >= 13
With this rewrite, the build of 117.0.5938.62 on 12.x will succeed and can be used.
However, I think it is actually better to fix the following.
#elif BUILDFLAG(IS_POSIX)
if (os_error != EAI_NONAME
#ifdef EAI_NODATA
&& os_error != EAI_NODATA
#endif
)
err = ERR_NAME_RESOLUTION_FAILED;
Regards.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?SI2PR01MB50363579B8F2F38B36A851F9FAF6A>