From nobody Mon Apr 3 19:50:25 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pr1hf0N9dz43Cr9; Mon, 3 Apr 2023 19:50:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pr1hd6kmPz4XBl; Mon, 3 Apr 2023 19:50:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680551426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zfB2BRdG407MJW0+EFwCkCRyynY+kcz5AammLcL8P4Y=; b=HfWkXfFD1lLfR1SnBnE4tSkpq91bWKu0wuribYqA/XVf5/k6Ch+xQEIROysAQb3SQDCkhs qo/pC0RMqifa68/0B6gBeK+3IIoCclRNY671/jFZl2I9XMjgXN1/rBVyl+7B2Sl9jy3tFC TUXemBVg2cPO2SVgHXymswUSgfu4/OMmLGHaN9tQWwLWonWyXIvAuIRoc1wNdur5TFM1GD npJKkp39jKRytfDuXz7rny3HNWBFfsj+qTfD31ZNDXJhVsW1jCkl7ApXVpeS9k3ok9koMH my/96u+r1woJqXu8NLeMEKKrOvIBSNbIaCJzxplt6TbAnYYDXm+jKQ0kW0UbmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680551426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zfB2BRdG407MJW0+EFwCkCRyynY+kcz5AammLcL8P4Y=; b=tYJjsDVLFsFjcDXYFebJIwgJw13LoB1O6PUIsjAnGaxEtcSnO5DdO/6AoYWgVSdLI3wdwQ HJM52OTEGVplabIOQRqWtBFNFt7bBiXvaC43HDTn4taeP1AXht/pUpZWu4WW+BbqwxK9L9 KFUPnTUOy+dCMv+1myiMp1aZWicQXNPsodvHikrQ362yr9rl/mipegVgM7A+oC2ME2Aju5 hFY7bfsKSOLnx+PTd5u4dlgYH/M8XYvtMMwyABYou9mAKMOWtCeVMtR01PDMlX0iQVRwaa ZPluXfDAY/yog0PBWg50cSZIXzBpFWGy/lG2peiU5JedMDcM59d2vQJXCWgMdg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680551426; a=rsa-sha256; cv=none; b=pzemp/hWimvEh91zLX6Pj2fEvvdz3+xaFKy46JkmxV1maOdXWjfHu7anSh5PbfeXPczMAM OfDmmaIdyhrKkJ9YbS9j930QM8D/rMmTrz2ROc9TJ3Ms3exq0Feh5kSJx0heK5BiY0zF6x uZpxG5oxJunpUQZXFsE0it/W4ThS7iQ1IUcLwoY8fvKho2vHcU+KIVEzTyAitqeDPiXb44 zcvrdUM4G7QBlx6iNw5/MigxAtnxwOBFC0+/SLzPV813+4QXoJOGvV4hloguBITAAvHI3x KKN1IUXz4NmJuJFiJB/R+jRt7P8mphW40y4GBP4EhQnUmzoGGnC6pADmUDPY5Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Pr1hd5rGNz1B42; Mon, 3 Apr 2023 19:50:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 333JoPha068649; Mon, 3 Apr 2023 19:50:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 333JoPRC068648; Mon, 3 Apr 2023 19:50:25 GMT (envelope-from git) Date: Mon, 3 Apr 2023 19:50:25 GMT Message-Id: <202304031950.333JoPRC068648@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: bef81bc0aef9 - main - setkey(8): ansify parser List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bef81bc0aef9dd4cd772b292d81bcc0ff7151d9f Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=bef81bc0aef9dd4cd772b292d81bcc0ff7151d9f commit bef81bc0aef9dd4cd772b292d81bcc0ff7151d9f Author: Konstantin Belousov AuthorDate: 2023-04-03 02:00:25 +0000 Commit: Konstantin Belousov CommitDate: 2023-04-03 19:48:49 +0000 setkey(8): ansify parser Sponsored by: NVidia networking MFC after: 1 week --- sbin/setkey/parse.y | 51 +++++++++++++-------------------------------------- sbin/setkey/token.l | 9 +++------ 2 files changed, 16 insertions(+), 44 deletions(-) diff --git a/sbin/setkey/parse.y b/sbin/setkey/parse.y index 0d8605c3409a..3d3ed123d4f0 100644 --- a/sbin/setkey/parse.y +++ b/sbin/setkey/parse.y @@ -773,11 +773,7 @@ policy_requests %% int -setkeymsg0(msg, type, satype, l) - struct sadb_msg *msg; - unsigned int type; - unsigned int satype; - size_t l; +setkeymsg0(struct sadb_msg *msg, unsigned type, unsigned satype, size_t l) { msg->sadb_msg_version = PF_KEY_V2; @@ -793,14 +789,8 @@ setkeymsg0(msg, type, satype, l) /* XXX NO BUFFER OVERRUN CHECK! BAD BAD! */ static int -setkeymsg_spdaddr(type, upper, policy, srcs, splen, dsts, dplen) - unsigned int type; - unsigned int upper; - vchar_t *policy; - struct addrinfo *srcs; - int splen; - struct addrinfo *dsts; - int dplen; +setkeymsg_spdaddr(unsigned type, unsigned upper, vchar_t *policy, + struct addrinfo *srcs, int splen, struct addrinfo *dsts, int dplen) { struct sadb_msg *msg; char buf[BUFSIZ]; @@ -892,12 +882,8 @@ setkeymsg_spdaddr(type, upper, policy, srcs, splen, dsts, dplen) /* XXX NO BUFFER OVERRUN CHECK! BAD BAD! */ static int -setkeymsg_addr(type, satype, srcs, dsts, no_spi) - unsigned int type; - unsigned int satype; - struct addrinfo *srcs; - struct addrinfo *dsts; - int no_spi; +setkeymsg_addr(unsigned type, unsigned satype, struct addrinfo *srcs, + struct addrinfo *dsts, int no_spi) { struct sadb_msg *msg; char buf[BUFSIZ]; @@ -1023,11 +1009,8 @@ setkeymsg_addr(type, satype, srcs, dsts, no_spi) /* XXX NO BUFFER OVERRUN CHECK! BAD BAD! */ static int -setkeymsg_add(type, satype, srcs, dsts) - unsigned int type; - unsigned int satype; - struct addrinfo *srcs; - struct addrinfo *dsts; +setkeymsg_add(unsigned type, unsigned satype, struct addrinfo *srcs, + struct addrinfo *dsts) { struct sadb_msg *msg; char buf[BUFSIZ]; @@ -1211,9 +1194,7 @@ setkeymsg_add(type, satype, srcs, dsts) } static struct addrinfo * -parse_addr(host, port) - char *host; - char *port; +parse_addr(char *host, char *port) { struct addrinfo hints, *res = NULL; int error; @@ -1232,8 +1213,7 @@ parse_addr(host, port) } static int -fix_portstr(spec, sport, dport) - vchar_t *spec, *sport, *dport; +fix_portstr(vchar_t *spec, vchar_t *sport, vchar_t *dport) { char *p, *p2; u_int l; @@ -1273,13 +1253,8 @@ fix_portstr(spec, sport, dport) } static int -setvarbuf(buf, off, ebuf, elen, vbuf, vlen) - char *buf; - int *off; - struct sadb_ext *ebuf; - int elen; - caddr_t vbuf; - int vlen; +setvarbuf(char *buf, int *off, struct sadb_ext *ebuf, int elen, caddr_t vbuf, + int vlen) { memset(buf + *off, 0, PFKEY_UNUNIT64(ebuf->sadb_ext_len)); memcpy(buf + *off, (caddr_t)ebuf, elen); @@ -1290,7 +1265,7 @@ setvarbuf(buf, off, ebuf, elen, vbuf, vlen) } void -parse_init() +parse_init(void) { p_spi = 0; @@ -1309,7 +1284,7 @@ parse_init() } void -free_buffer() +free_buffer(void) { /* we got tons of memory leaks in the parser anyways, leave them */ } diff --git a/sbin/setkey/token.l b/sbin/setkey/token.l index 1cf2a43fe323..44b1ffbfaa32 100644 --- a/sbin/setkey/token.l +++ b/sbin/setkey/token.l @@ -253,23 +253,20 @@ any { return(ANY); } %% void -yyfatal(s) - const char *s; +yyfatal(const char *s) { yyerror(s); exit(1); } void -yyerror(s) - const char *s; +yyerror(const char *s) { printf("line %d: %s at [%s]\n", lineno, s, yytext); } int -parse(fp) - FILE **fp; +parse(FILE **fp) { yyin = *fp;