From owner-dev-commits-ports-all@freebsd.org Thu Jul 15 17:07:04 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A7DE64AD78; Thu, 15 Jul 2021 17:07:04 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GQglW5HQRz4nJt; Thu, 15 Jul 2021 17:07:03 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 12D12E1F4B; Thu, 15 Jul 2021 19:06:54 +0200 (CEST) Date: Thu, 15 Jul 2021 19:06:52 +0200 From: Piotr Kubaj To: Alexey Dokuchaev Cc: Guido Falsi , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: dc9bf7d64926 - main - net/asterisk*: Add aarch64 support Message-ID: References: <202107141033.16EAX60T044972@gitrepo.freebsd.org> <81bc6b76-7b74-9990-d7dc-54ca14b0ee4f@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KbORwR30tU053l5G" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4GQglW5HQRz4nJt X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.38 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEFALL_USER(0.00)[pkubaj]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:46.248.190.61]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MID_RHS_NOT_FQDN(0.50)[]; ARC_NA(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; SPAMHAUS_ZRD(0.00)[46.248.190.61:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RBL_DBL_DONT_QUERY_IPS(0.00)[46.248.190.61:from]; NEURAL_HAM_LONG(-0.98)[-0.982]; DMARC_POLICY_ALLOW(-0.50)[anongoth.pl,reject]; NEURAL_HAM_SHORT(-1.00)[-1.000]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main] X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2021 17:07:04 -0000 --KbORwR30tU053l5G Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21-07-15 16:59:37, Alexey Dokuchaev wrote: > On Thu, Jul 15, 2021 at 04:38:53PM +0200, Guido Falsi wrote: > > On 15/07/21 04:06, Alexey Dokuchaev wrote: > > > ... > > > I think ONLY_FOR_ARCHS here clearly outlived its purpose and can just > > > be removed. It arguably misses MIPS, but we aren't promising much for > > > that tier anyways, and this harness just gets in the way of those who > > > know that they're doing. After all, there shouldn't be anything > > > inherently architecture-specific about the telephony toolkit, but even > > > if there is, individual BROKEN_$arch would be more appropriate. > >=20 > > The fact that mips is not included is exactly the reason I did not > > remove ONLY_FOR_ARCHS. > >=20 > > If what you say is the general consensus I'll be quite happy to get rid > > of it. >=20 > You'd likely not get general consensus as most people don't care. :-) >=20 > > I guess this compiler mix situation is not an issue anymore. >=20 > Right. I think it's generally bad idea to prematurely restrict software > to certain arches unless it's clearly arch-specific (e.g. comes only in > binary precompiled form or uses asm code). New arches appear frequently > (e.g. powerpc64le, riscv64) and some go away as well (ia64, sparc64), it > just does not look feasible to maintain those ONLY_FOR_ARCHS lists so > they'd always reflect the reality. This is the reason I prefer NOT_FOR_ARCHS - it doesn't require any interven= tion after adding new architectures. >=20 > Even if one's port does break on MIPS, one should get a notice from the > build cluster and either fix it, or mark is as BROKEN_$arch, rather than > keep ONLY_FOR_ARCHS which would only get amended, causing needless repo > churn, upon every next time someone discovers that it builds and works > on their architecture of interest. >=20 > ./danfe --KbORwR30tU053l5G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmDwaywACgkQelmbhSCD nJ219g/9HORv0PzbLgM6LvgVE9ymxyHRb4AA5nXj9rJazTbyxcMScpcXNv/pA6wj 0sGCER2EAN2vkbURbX4LxIUrfh1CD8y4hbX6okpTmt2/8M5XO0VzBAJlcz9dFUlV GIh/+bHuahFtNYnV2TGNyH+XF8XVI+bTPOOa8Ly+9XIVnYRRj3TfdDvtEUfqSTp/ nbHeXu9YQLNL1uP7D1WNSfHMLstdd6AG1oSMLFdOsCDfi3+kuqPhGVpNOGmeTfAi 3FKr/rpcc2K13W5sOAD1nF/gNRaXN1HU/LTODRBgGuLaRuFAQ8MfnqgOfJsiCl73 CvYx6pjixH9Yt6gXBGHTUN/+eQNkFw0jPzwh5bMq3V9P0iUu34BI2Yv14bo0Nq9E oj6ZNAsSTPIxSyGtoP/L0JJfou02XyoCGL7YTT88PS85Z93dYUSSU3qBHGCmOox5 EV04xUeuwE0WVTpc1CaREOI9dS+nVLf6v99AWuSu2lPYAbb4eaI+wOr+3ehpBcAW 2qT1bViS3rcxRaBJ52B764VornhGEfbnISFs/8EM+iCILtl/FLYIeIvZqNdqzIIp f3XXehXUbH0udvZe+MNRotJmE/NBHOJld9nrxQ2suI5sEU4fvP6PPKAUxfFg+FLN N85dHHGrfq2i4cdzM9OTxp/SFUCNWwSbRXMzBno0IFwA5OpIG9g= =A83X -----END PGP SIGNATURE----- --KbORwR30tU053l5G--