Date: Thu, 21 Aug 2014 20:28:06 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Hiroki Sato <hrs@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r365590 - in head/cad/spice: . files Message-ID: <53F69CA6.1060909@FreeBSD.org> In-Reply-To: <53F6724A.6000602@marino.st> References: <201408211941.s7LJf6de048334@svn.freebsd.org> <53F663B2.3000800@marino.st> <20140822.070939.1253386656808735449.hrs@allbsd.org> <53F66EE5.7080500@FreeBSD.org> <53F6724A.6000602@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Tdqp01SfH3dhTW5e5ntTOTEFS3nv97PdN Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 8/21/2014 5:27 PM, John Marino wrote: >=20 > On 8/22/2014 00:12, Bryan Drewery wrote: >> On 8/21/2014 5:09 PM, Hiroki Sato wrote: >>> John Marino <freebsd.contact@marino.st> wrote >>> in <53F663B2.3000800@marino.st>: >>> >>> fr> On 8/21/2014 21:41, Hiroki Sato wrote: >>> fr> > Author: hrs >>> fr> > Date: Thu Aug 21 19:41:06 2014 >>> fr> > New Revision: 365590 >>> fr> > URL: http://svnweb.freebsd.org/changeset/ports/365590 >>> fr> > QAT: https://qat.redports.org/buildarchive/r365590/ >>> >>> ... >>> >>> fr> I'm sorry, but using freebsd-specific <bsd.prog.mk> in a ports ve= ndor >>> fr> makefile is NOT an improvement and frankly puts the build at risk= on >>> fr> DragonFly. >>> fr> >>> fr> I wish there was a rule that ports should not use system make fra= gments. >>> fr> This is not a good practice. This port had a perfectly working = and >>> fr> generic makefile before. >>> fr> >>> fr> There's a good chance this just broke spice on DragonFly as the s= ystem >>> fr> make file these are different. >>> >>> I can understand that vendor's Makefile should be platform-neutral, >>> but I do not think there is advantage to maintain >>> ${FILESDIR}/Makefile in a way not to use FreeBSD-specific stuff >>> because it is used only by the port. Should we care about build on >>> DragonFly? >> >> No! This is FreeBSD. Ports is only officially supported on FreeBSD. >> >> There are plenty of other ports using bsd.prog.mk. >=20 > Putting the first statement aside which frankly contradicts other > statements made by other portmgr and completely belittles my > contributions, this is a bad idea for FreeBSD too. You are not > containing the port to ports collection. If the system makefile > fragment changes, it affects the port. It's a dumb decision. If you > want these makefile fragments, put a tailored copy of Mk/ >=20 > In this PARTICULAR case, I staged the port. I fixed that makefile. HR= S > changes serve no purpose other than to potentially break my work. > Obviously that is not his intention, but that is the result. >=20 > Frankly he should revert this immediately. It was working before > everywhere. This attitude is completely wrong. This is FreeBSD ports. You should not be harping on people for writing to FreeBSD. Whatever bapt has told has told you does not negate this. We support you using FreeBSD for dports but the fact is that dports is a fork anyway. Nothing is stopping you from modifying dports for these fixes where required. It really is not okay to be giving people this sort of response. Asking someone to use a more portable change for the sake of upstreaming and use on DragonFly is fine. Screaming that they are are only changing things to break your work is not, or that they are doing things wrong when they are perfectly fine in the normal 20 year convention is not. You, and possibly bapt, are the only committers who really care about getting ports working on DragonFly. Please consider that next time you bring it up. Others are offended by you demanding they change things or that they did it wrong for DFLY. Regarding this individual change, you have provided no evidence it breaks anywhere. And as I've pointed out there are plenty of other ports using bsd.prog.mk. 127 files reference it. It is perfectly reasonable for someone to use bsd.prog.mk in ports. >=20 > John >=20 --=20 Regards, Bryan Drewery --Tdqp01SfH3dhTW5e5ntTOTEFS3nv97PdN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJT9pymAAoJEDXXcbtuRpfPy+UH/3/rAGa/2kzK4rFbvLG3hlqK jGC2OImi2w8mh9XwwrtREmObGBnpbAsI4y1ByDCy6cGnLsGQ4HmrpbCQFKZwbq68 BLpUYcdrqPkYPsGRDpiVNfq7LISm7DU4sUMks6X8LU3V9sdjjD5htdml0W0cNfzq drKDR8PbGcvJmLPLkwGlhf8X2us+AZjpY2jOoU2tqD7PJ+yB4Frmn8YUEEjmr3tC 6gz82h2HrmhElCJ7ZO4hxiCMleQmEtqzim8dRDIOAGZGL/73aMj+l/OWKo682k/8 ghSROBzD6zyCXFxPnyhHhlldCbnxSyeXmFQd4yBH3/Ot9NQEk6wmzE6Zsc19xdo= =L7Ch -----END PGP SIGNATURE----- --Tdqp01SfH3dhTW5e5ntTOTEFS3nv97PdN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53F69CA6.1060909>