From owner-freebsd-net@FreeBSD.ORG  Tue Feb 17 17:50:11 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C8F5DB24
 for <freebsd-net@freebsd.org>; Tue, 17 Feb 2015 17:50:11 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 830388D3
 for <freebsd-net@freebsd.org>; Tue, 17 Feb 2015 17:50:11 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t1HHoBFi003239
 for <freebsd-net@freebsd.org>; Tue, 17 Feb 2015 17:50:11 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHoB99003238;
 Tue, 17 Feb 2015 17:50:11 GMT (envelope-from root)
Date: Tue, 17 Feb 2015 17:50:11 +0000
To: freebsd-net@freebsd.org
From: "rrs (Randall Stewart)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D1711: Changes to the callout code to
 restore active semantics and also add a test-framework and test to validate
 thecallout code (and potentially for use by other tests).
Message-ID: <8ea9c2935d1adfeeceb29ea19aeffca2@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1711: Changes to the callout code to restore active semantics
 and also add a test-framework and test to validate the callout code (and
 potentially for use by other tests).
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-nb2boxugvmpo7syia5md>
X-Phabricator-To: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-To: <PHID-USER-xs5piezwnsa6epounp3t>
X-Phabricator-To: <PHID-USER-s22ldiy33wseno7vfmzs>
X-Phabricator-To: <PHID-USER-iv3vop5y36l265phkqzr>
X-Phabricator-To: <PHID-USER-2wocyy2vsyzu2nddvuw6>
X-Phabricator-To: <PHID-USER-u62wa6uhdoiyjmodxchd>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-mdwvnzzsrozqcmzhmbra>
X-Phabricator-Cc: <PHID-USER-mhzsgq7klbzjcspjzvus>
X-Phabricator-Cc: <PHID-USER-hh4avozwa3ssphnwhjxx>
X-Phabricator-Cc: <PHID-USER-iv3vop5y36l265phkqzr>
X-Phabricator-Cc: <PHID-USER-2wocyy2vsyzu2nddvuw6>
X-Phabricator-Cc: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-Cc: <PHID-USER-n3y55yy4j7xarsdk3otz>
X-Phabricator-Cc: <PHID-USER-fbdcs7ahjev7eqpeqr2a>
X-Phabricator-Cc: <PHID-USER-k4sj4wabur5mtroxrat2>
X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc>
In-Reply-To: <differential-rev-PHID-DREV-vhk6ww63dvpj6egspuyt-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-vhk6ww63dvpj6egspuyt-req@FreeBSD.org>
Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjf1M=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Feb 2015 17:50:11 -0000

rrs added a comment.

Hiren:

There also should have been a printf before the panic string
 printf( "spin lock %p (%s) held by %p (tid %d) too long\n",
            m, m->lock_object.lo_name, td, td->td_tid);

Can we see what that lovely printf has displayed?

In theory the lo_name should be "callout" and the %p should point to &cc_cpu[0].cc_lock

Can we validate that these align correctly too?

REVISION DETAIL
  https://reviews.freebsd.org/D1711

To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky
Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net