From owner-svn-src-head@FreeBSD.ORG  Tue Jul 20 17:04:40 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 21575106575E
	for <svn-src-head@freebsd.org>; Tue, 20 Jul 2010 17:04:40 +0000 (UTC)
	(envelope-from kozlov@ravenloft.kiev.ua)
Received: from hosting.nash.net.ua (hosting.nash.net.ua [193.151.252.10])
	by mx1.freebsd.org (Postfix) with SMTP id 570E88FC12
	for <svn-src-head@freebsd.org>; Tue, 20 Jul 2010 17:04:38 +0000 (UTC)
Received: (qmail 9059 invoked by uid 509); 20 Jul 2010 17:04:38 -0000
Received: from ravenloft.kiev.ua (94.244.131.95)
	by hosting.nash.net.ua with SMTP; 20 Jul 2010 17:04:38 -0000
Date: Tue, 20 Jul 2010 20:03:33 +0300
From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: Jilles Tjoelker <jilles@stack.nl>, Gabor Kovesdan <gabor@FreeBSD.org>,
	svn-src-head@freebsd.org, spam@rm-rf.kiev.ua
Message-ID: <20100720170333.GA51595@ravenloft.kiev.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Cc: 
Subject: Re: svn commit: r210254 - in head/etc: defaults periodic/security
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jul 2010 17:04:40 -0000

On Tue, Jul 20, 2010 at 05:25:05PM +0300, Alex Kozlov wrote:
> > > +				echo ${name}: ${one}
> > 
> > This handles pathnames with spaces incorrectly. Consider reading lines
> > with
> >   IFS= read -r line
> > This also collapses the nested case statements to one, for
> > 'Information for'*, Mismatched*, '' and /*.
> > 
> > The variables in the echo commands should be quoted to avoid word
> > splitting and pathname generation.
> It's makes parser stateful and overly complex, I will think about most
> simple way to do this. Fortunately, at the moment very few, if any, ports
> have files with space in names.
It's seems I was wrong, We have more that 10k files with spaces in ports.
What do think about this solution?

Index: etc/periodic/security/460.chkportsum
@@ -26,8 +26,10 @@
 			;;
 			Mismatched|'') ;;
 			*)
-			if [ -n ${name} ]; then
-				echo ${name}: ${one}
+			if [ -n "${name}" ]; then
+				#handle filenames with spaces
+				file="${one} ${two} ${three}"
+				echo "${name}: ${file%% fails the original MD5 checksum}"
 			fi
 			;;
 		esac


--
Adios