From owner-svn-ports-head@FreeBSD.ORG Thu Jul 24 09:08:21 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ADDF5F46; Thu, 24 Jul 2014 09:08:21 +0000 (UTC) Received: from mailrelay012.isp.belgacom.be (mailrelay012.isp.belgacom.be [195.238.6.179]) by mx1.freebsd.org (Postfix) with ESMTP id CA2B827BA; Thu, 24 Jul 2014 09:08:20 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApQJAAjM0FNbs4XT/2dsb2JhbABZgw5STQvJBYdFAYEJF3eEBAEFOhwjEAsUBAklDyoeBohZAQi/dxePGDMHhEYBBJsygVOScINKOw Received: from 211.133-179-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.179.133.211]) by relay.skynet.be with ESMTP; 24 Jul 2014 11:07:08 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id s6O977uH001518; Thu, 24 Jul 2014 11:07:07 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Thu, 24 Jul 2014 11:07:07 +0200 From: Tijl Coosemans To: Sunpoet Po-Chuan Hsieh Subject: Re: svn commit: r362762 - head/sysutils/freeipmi Message-ID: <20140724110707.690e7fe7@kalimero.tijl.coosemans.org> In-Reply-To: <201407240511.s6O5Btub011489@svn.freebsd.org> References: <201407240511.s6O5Btub011489@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2014 09:08:21 -0000 On Thu, 24 Jul 2014 05:11:55 +0000 (UTC) Sunpoet Po-Chuan Hsieh wrote: > Author: sunpoet > Date: Thu Jul 24 05:11:54 2014 > New Revision: 362762 > URL: http://svnweb.freebsd.org/changeset/ports/362762 > QAT: https://qat.redports.org/buildarchive/r362762/ > > Log: > - Fix build on 11-CURRENT > > Modified: > head/sysutils/freeipmi/Makefile > > Modified: head/sysutils/freeipmi/Makefile > ============================================================================== > --- head/sysutils/freeipmi/Makefile Thu Jul 24 05:01:54 2014 (r362761) > +++ head/sysutils/freeipmi/Makefile Thu Jul 24 05:11:54 2014 (r362762) > @@ -24,7 +24,7 @@ CONFIGURE_ARGS= --disable-init-scripts \ > --with-ipmi-monitoring-sdr-cache-dir=${CACHE_DIR}/ipmimonitoringsdrcache \ > --with-pkgconfig-dir=${PREFIX}/libdata/pkgconfig > CONFIGURE_ENV= PTHREAD_LIBS=-pthread ac_cv_path_CPP=${CPP} > -CPPFLAGS+= -I${LOCALBASE}/include > +CPPFLAGS+= -fPIC -I${LOCALBASE}/include Adding -fPIC like that is almost always wrong, because now you also build executables and static libraries with it. This port builds fine without -fPIC on beefy and redports so what exactly is the problem? Same for r362761.