From owner-svn-src-all@freebsd.org  Fri May 11 14:50:35 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25917FD8800;
 Fri, 11 May 2018 14:50:35 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 32B2B76299;
 Fri, 11 May 2018 14:50:33 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w4BEoQh9075793;
 Fri, 11 May 2018 07:50:26 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w4BEoQRS075792;
 Fri, 11 May 2018 07:50:26 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201805111450.w4BEoQRS075792@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r333476 - head/sys/net
In-Reply-To: <86wowauumi.fsf@next.des.no>
To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
Date: Fri, 11 May 2018 07:50:26 -0700 (PDT)
CC: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 May 2018 14:50:35 -0000

> This booted and runs without issue, although obviously I wouldn't want
> to commit it:

Looks pretty close to what I did the first time.
We could also wrap this in my proposed ifdef,
and add a sysctl() to turn it on and off though
it would probably be beter to do that in the code
areas that bde patches this out.

> 
> Index: sys/net/if.c
> ===================================================================
> --- sys/net/if.c	(revision 333490)
> +++ sys/net/if.c	(working copy)
> @@ -1814,6 +1814,7 @@
>  ifa_maintain_loopback_route(int cmd, const char *otype, struct ifaddr *ifa,
>      struct sockaddr *ia)
>  {
> +#if 0
#ifdef MAINTAIN_LOOPBACK_ROUTE

>  	int error;
>  	struct rt_addrinfo info;
>  	struct sockaddr_dl null_sdl;
> @@ -1837,6 +1838,9 @@
>  		if_printf(ifp, "%s failed: %d\n", otype, error);
>  
>  	return (error);
> +#else
> +	return (0);
> +#endif
>  }
>  
>  int
> 
> DES
> -- 
> Dag-Erling Sm?rgrav - des@des.no
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org