Date: Wed, 16 May 2001 20:36:26 -0700 From: Peter Wemm <peter@wemm.org> To: John Baldwin <jhb@FreeBSD.ORG> Cc: Matthew Jacob <mjacob@feral.com>, current@FreeBSD.ORG, Bob Bishop <rb@gid.co.uk> Subject: Re: panic: sleeping process owns a mutex Message-ID: <20010517033626.D33BC3811@overcee.netplex.com.au> In-Reply-To: <XFMail.010516151938.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:
>
> On 16-May-01 Matthew Jacob wrote:
> >
> > Oh, I'd like you to think twice about this. Massive amounts of driver
> > rototilling should be avoided at this point.
>
> Well, it's causing panics in some cases. Those are bad. Basically I would b
e
> reverting earlier changes.
For most of the drivers it is farly low impact. Simply replace things like
this:
#define FOO_LOCK(sc) mtx_lock(sc->sc_mtx);
#define FOO_UNLOCK(sc) mtx_unlock(sc->sc_mtx);
with:
#if 0
#define FOO_LOCK(sc) mtx_lock(sc->sc_mtx);
#define FOO_UNLOCK(sc) mtx_unlock(sc->sc_mtx);
#else
#define FOO_LOCK(sc)
#define FOO_UNLOCK(sc)
#endif
That should at least discourage more cut/paste of the same broken locking
logic into new drivers.
> > On Wed, 16 May 2001, John Baldwin wrote:
> >
> >>
> >> On 16-May-01 Bob Bishop wrote:
> >> > Hi,
> >> >
> >> > This while building world, with a kernel cvsup at Fri Apr 27 04:06:40 BS
T
> >> > 2001
> >> >
> >> > kern/kern_synch.c:386 sleeping with "vr0" locked from pci/if_vr.c:1315
> >> >
> >> > abridged backtrace:
> >> >
> >> > panic()
> >> > propagate_priority()
> >> > _mtx_lock_sleep()
> >> > vr_intr()
> >> > ithread_loop()
> >> > fork_exit()
> >> > fork_trampoline()
> >>
> >> Well, I think the best thing to do for now will be to back out all the
> >> ethernet
> >> driver locking until we figure out how we are actually going to lock them.
> >> The original locks that went in starting with fxp many months ago weren't
> >> quite
> >> right but have been mostly harmless up to this point. There are some cas
es
> >> where we sleep with locks however, which can lead to problems.
> >>
> >> --
> >>
> >> John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
> >> PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
> >> "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
> >>
> >> To Unsubscribe: send mail to majordomo@FreeBSD.org
> >> with "unsubscribe freebsd-current" in the body of the message
> >>
> >
>
> --
>
> John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
> PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
> "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
>
>
Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010517033626.D33BC3811>