Date: Mon, 14 Aug 2023 15:53:51 GMT From: Eric Joyner <erj@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 8e6654a6a551 - main - ofed: fix roce gid insertion for vlan interfaces Message-ID: <202308141553.37EFrpOU060103@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by erj: URL: https://cgit.FreeBSD.org/src/commit/?id=8e6654a6a5511da87de03a91c527e1d7ad006c21 commit 8e6654a6a5511da87de03a91c527e1d7ad006c21 Author: Bartosz Sobczak <bartosz.sobczak@intel.com> AuthorDate: 2023-08-14 15:49:26 +0000 Commit: Eric Joyner <erj@FreeBSD.org> CommitDate: 2023-08-14 15:53:43 +0000 ofed: fix roce gid insertion for vlan interfaces When attempting to use vlan interface the correct GID wasn't created due to incorrect ifp validation. The problem was introduced in 3e142e07675b ('ofed: Mechanically convert to IfAPI) Signed-off-by: Bartosz Sobczak bartosz.sobczak@intel.com Signed-off-by: Eric Joyner <erj@FreeBSD.org> PR: 273043 Sponsored by: Intel Corporation Reviewed by: jhibbits@, erj@ MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D41426 --- sys/ofed/drivers/infiniband/core/ib_roce_gid_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/ofed/drivers/infiniband/core/ib_roce_gid_mgmt.c b/sys/ofed/drivers/infiniband/core/ib_roce_gid_mgmt.c index 1396a4aacf3a..0acb16935986 100644 --- a/sys/ofed/drivers/infiniband/core/ib_roce_gid_mgmt.c +++ b/sys/ofed/drivers/infiniband/core/ib_roce_gid_mgmt.c @@ -239,7 +239,7 @@ roce_gid_update_addr_callback(struct ib_device *device, u8 port, if (ifp != ndev) { if (if_gettype(ifp) != IFT_L2VLAN) continue; - if (ifp != rdma_vlan_dev_real_dev(ifp)) + if (ndev != rdma_vlan_dev_real_dev(ifp)) continue; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308141553.37EFrpOU060103>