From owner-dev-commits-src-main@freebsd.org Mon May 31 23:48:54 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E7F436335D4 for ; Mon, 31 May 2021 23:48:54 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FvBny5ms5z3QcN for ; Mon, 31 May 2021 23:48:54 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f44.google.com with SMTP id l2so4861979wrw.6 for ; Mon, 31 May 2021 16:48:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=xCvDxSo7ZvkCxJ+IhtsPxBI0eiRep2ak2nmuufA1jEk=; b=AM9SMalQLSPIi30dBd0oesD+nz0FQr5VMSeDH+66pH/zdwkXd4mw+R5S8c0/oz6Pgb nix8QqtdVi6uuvRvWHs+z0NTtIY+wRA4LRwlMf5/zIY6ib/mhBg/HwvlSzqvdZ16UWc3 qwh2/CcJC80IshBZhFPlHX6ApQ2eYcYexUsbbZFa/a4+C/gjWEr8rXRK4d8NBdSeLvla jjjNW1LyOc6YdzQEQ8/WhD3ai2HbIgHzksERegjr3b2DN7DkD54op2MuNW+pSvAwNdln rhmqODGGDm/MLvn8aLUG7bw/lh8UTympVAb6DQl2fC0RS0c7foeFzqX01yCgXh44Jpab lu3A== X-Gm-Message-State: AOAM532ri2eOtTZHb9/+Sviuv2lYPsvS0IznRSQCsk+wq2sy/X7Bf1jk Nehut/MmFxqkEO/saeiqoOQuew== X-Google-Smtp-Source: ABdhPJxwxdIo+4yVyiVvZbSNv6ML5t3dfPPdNMqqwbWO+vxBWjhwkmIX4ypm6jMNx456oJMuE/S+TQ== X-Received: by 2002:adf:fa46:: with SMTP id y6mr16102369wrr.194.1622504933379; Mon, 31 May 2021 16:48:53 -0700 (PDT) Received: from smtpclient.apple (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id n9sm7006513wmc.20.2021.05.31.16.48.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 May 2021 16:48:52 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: git: 18f55c67f746 - main - x86: Fix lapic_ipi_alloc() on i386 From: Jessica Clarke In-Reply-To: <202105312309.14VN9nWf040168@gitrepo.freebsd.org> Date: Tue, 1 Jun 2021 00:48:52 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202105312309.14VN9nWf040168@gitrepo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Rspamd-Queue-Id: 4FvBny5ms5z3QcN X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 May 2021 23:48:55 -0000 On 1 Jun 2021, at 00:09, Mark Johnston wrote: >=20 > The branch main has been updated by markj: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D18f55c67f746f0ad12fe972328234d34= 0a621df9 >=20 > commit 18f55c67f746f0ad12fe972328234d340a621df9 > Author: Mark Johnston > AuthorDate: 2021-05-31 22:51:14 +0000 > Commit: Mark Johnston > CommitDate: 2021-05-31 22:51:14 +0000 >=20 > x86: Fix lapic_ipi_alloc() on i386 >=20 > The loop which checks to see if "dynamic" IDT entries are allocated > needs to compare with the trampoline address of the reserved ISR. > Otherwise it will never succeed. >=20 > Reported by: Harry Schmalzbauer > Tested by: Harry Schmalzbauer > Reviewed by: kib > MFC after: 1 week > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D30576 > --- > sys/x86/x86/local_apic.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/sys/x86/x86/local_apic.c b/sys/x86/x86/local_apic.c > index 5b4910d4b891..bb575d0c601d 100644 > --- a/sys/x86/x86/local_apic.c > +++ b/sys/x86/x86/local_apic.c > @@ -2127,6 +2127,10 @@ native_lapic_ipi_vectored(u_int vector, int = dest) >=20 > #endif /* SMP */ >=20 > +#ifdef __i386__ > +extern uintptr_t setidt_disp; uintptr_t here is fishy. Should it not be size_t or ptrdiff_t? Jess