From owner-cvs-sys  Sat Jul 20 21:30:31 1996
Return-Path: owner-cvs-sys
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id VAA11073
          for cvs-sys-outgoing; Sat, 20 Jul 1996 21:30:31 -0700 (PDT)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id VAA11063;
          Sat, 20 Jul 1996 21:30:18 -0700 (PDT)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id OAA24600; Sun, 21 Jul 1996 14:26:37 +1000
Date: Sun, 21 Jul 1996 14:26:37 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199607210426.OAA24600@godzilla.zeta.org.au>
To: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-sys@freefall.freebsd.org, joerg@freefall.freebsd.org
Subject: Re: cvs commit:  src/sys/i386/isa aha1542.c
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

>  Modified:    sys/i386/isa  aha1542.c
>  Log:
>  Replace the annoying calls to Debugger() by panic()'s in the
>  #ifdef DIAGNOSTIC case, and a warning only otherwise.

I think they should be panics in all cases.  The original version may have
expected Debugger() to cause a fatal trap if ddb is not installed.  ISTR
"fixing" Debugger() to make it non-fatal.  This was a mistake.

>  People who want them to break into the debugger can always set the
>  breakpoint explicitly.  The existing behaviour was a misfeature from

Yes, code with Debugger() in it (except code to explicitly trap to the
debugger) shouldn't be committed.

>  the beginning, in the (wrong) assumption that the SCSI controller must
>  always be of essential importance to the entire system.

It is, if the alterative is to write corrupted data.

Bruce