From nobody Fri Sep 19 18:05:28 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cT0mQ6RjJz68Lng; Fri, 19 Sep 2025 18:05:42 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cT0mP50YSz4QGv; Fri, 19 Sep 2025 18:05:41 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 58JI5S3K022092; Fri, 19 Sep 2025 21:05:31 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 58JI5S3K022092 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 58JI5S2V022091; Fri, 19 Sep 2025 21:05:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 19 Sep 2025 21:05:28 +0300 From: Konstantin Belousov To: Colin Percival Cc: Konstantin Belousov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 94a0f9f63e16 - main - kern/vfs_vnops.c: generalize the lock primitive for file foffset Message-ID: References: <202509191419.58JEJrSZ031832@gitrepo.freebsd.org> <0100019963022db0-d88b1d01-e0f3-4ec3-9838-a7f8f66f6c1f-000000@email.amazonses.com> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0100019963022db0-d88b1d01-e0f3-4ec3-9838-a7f8f66f6c1f-000000@email.amazonses.com> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.82 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.92)[-0.921]; NEURAL_HAM_MEDIUM(-0.90)[-0.901]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MISSING_XM_UA(0.00)[]; HAS_XAW(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_DKIM_NA(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4cT0mP50YSz4QGv On Fri, Sep 19, 2025 at 05:25:11PM +0000, Colin Percival wrote: > On 9/19/25 07:19, Konstantin Belousov wrote: > > commit 94a0f9f63e164e4f3791bc7d105d6f267b4d47bc > > > > kern/vfs_vnops.c: generalize the lock primitive for file foffset > > > > + atomic_clear_16(flagsp, lock_bit | lock_wait_bit); > > Jenkins says this breaks powerpc64: > > /usr/src/sys/kern/vfs_vnops.c:852:2: error: call to undeclared function > 'atomic_clear_16'; ISO C99 and later do not support implicit function > declarations [-Werror,-Wimplicit-function-declaration] > 852 | atomic_clear_16(flagsp, lock_bit | lock_wait_bit); > | ^ > /usr/src/sys/kern/vfs_vnops.c:852:2: note: did you mean 'atomic_clear_int'? D52626