From owner-freebsd-current@FreeBSD.ORG Mon Jul 28 10:14:37 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4693837B401 for ; Mon, 28 Jul 2003 10:14:37 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 1606543FA3 for ; Mon, 28 Jul 2003 10:14:36 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 52944 invoked by uid 1000); 28 Jul 2003 17:14:36 -0000 Date: Mon, 28 Jul 2003 10:14:36 -0700 (PDT) From: Nate Lawson To: "Justin T. Gibbs" In-Reply-To: <816330000.1059408846@aslan.btc.adaptec.com> Message-ID: <20030728101124.O52934@root.org> References: <20030728061606.046BC37B401@hub.freebsd.org> <20030727231701.N51710@root.org> <816330000.1059408846@aslan.btc.adaptec.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: current@freebsd.org cc: scsi@freebsd.org Subject: Re: cvs commit: src/sys/cam cam_ccb.h src/sys/cam/scsi scsi_cd.c scsi_da.c src/sys/dev/ata atapi-cam.c src/sys/dev/usb umass.c src/sys/dev/firewire sbp.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jul 2003 17:14:37 -0000 On Mon, 28 Jul 2003, Justin T. Gibbs wrote: > > After this code is in both stable and current, current USB quirks will be > > deprecated but can be re-enabled in a pinch with a kernel option. > > Unfortunately, I only have contact information for the more recent quirks > > that were committed and so the only way to find devices that have other > > problems (i.e. NO_SYNC_CACHE) is to disable the quirks and re-enable them > > for devices that still fail. > > Did you ever find the bug in the sync cache "silence errors" code that > was the root cause for most of the quirks? Most of the quirks were added for NO_6_BYTE. Many of the USB devices include NO_SYNC_CACHE also although the documentation for many of these was lost before we began keeping PRs documenting the issue. Many of the devices that include NO_SYNC_CACHE were just cut/pasted from previous quirks and no attempt was made to verify the separate need for that quirk. I'll do my best to follow down cvs logs and things but what it comes down to is that we'll just have to test to see what quirks are really needed. -Nate