From owner-svn-ports-all@freebsd.org Wed Aug 14 22:35:25 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 09582BDBBB for ; Wed, 14 Aug 2019 22:35:25 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4684Cw1g1rz45RZ for ; Wed, 14 Aug 2019 22:35:24 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-wm1-x341.google.com with SMTP id g67so95670wme.1 for ; Wed, 14 Aug 2019 15:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YC7aOWF2pWEJDU0q8tDl6YBnrn4p+LErp8ydIOWfRLw=; b=Xs486nbOD60VN1TrUx903/umuz9yvNvruJX3OuLymIVSo5hSD4PJtdNw9AGB5NKnuB 8vfSCAGGHTp5aFGT3bBwPILApYUf2XOk/pZmEiauXoqO/3iBLN0WgF1DjHSIfMNCtuS/ sINwLaViloZ8Gj6ObASz7LKvl25+SE4Vwqd+wXx8O8/iHQU4pSqCOWE90j4vMSBMYvtD 9YBViKN0SsUCNgTQbKESCq68bKvTdD/c/B19fVXIncrpBFNpIt8ySW0oa9X5/gPzO5d0 rCgyr311aDtPOLS911pWsZL3wlZY43K+2ghJSgtlwR/IRRbB8efAv/Ne5jpJGj1BzpFc 1P2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YC7aOWF2pWEJDU0q8tDl6YBnrn4p+LErp8ydIOWfRLw=; b=pcLSE0Q4ECBS6AWQRJkhMOP1ogf59iaEVDuZ6lLsMZVoqBppQ9tJZdjPJUPoxeCesH lJO+/Eg6Ew9vHCj0GIuWC3X07ywRYE2aCVpHReVMUfEurcumCg39NAjmAuU/AIpFLXH0 OMgsBma/Sn5bSkHA0/hw/YfjxpkUaXhnS5Y3GHcX8E98H5fuN49dvDjc26WCH9j5rSYS Ay0uWprxOh9CAKkXzwj9zAnA3sE5Ket0km4njU2rKesrkN+05YeLOE95yhVQy1cZew9m 0r63vBGEW3gPJzxM237OEAHTlALdAEP1B9bl9DDkwip1/45oP6bXjVrVpzX6fklum2UF I9Gw== X-Gm-Message-State: APjAAAXBBgXl6wP7j3uiHGcFptzmvsfq+Yb2zb4Jy50Y8YezEtVusKWN GZ3MsRns/9rSE/F57MpjX/kTGAnOpSPv5OLTWfwcEA== X-Google-Smtp-Source: APXvYqwA+Wxyn7GhkUHDZiMSnJChXOdFCejp8ZZAYd25yQEj5qiE07N/cn73rI641mr3eUtN3po/KqzrphX0EX9yRGs= X-Received: by 2002:a1c:1f41:: with SMTP id f62mr102343wmf.176.1565822122077; Wed, 14 Aug 2019 15:35:22 -0700 (PDT) MIME-Version: 1.0 References: <201908141418.x7EEIbcB050123@repo.freebsd.org> <5316998.XOh7uYVVfo@beastie.bionicmutton.org> In-Reply-To: <5316998.XOh7uYVVfo@beastie.bionicmutton.org> From: Adam Weinberger Date: Wed, 14 Aug 2019 16:35:06 -0600 Message-ID: Subject: Re: svn commit: r508922 - in head: databases/opendbviewer devel/cmake devel/cmake-doc devel/cmake-gui devel/cmake/files devel/kms-cmake-utils graphics/peruse/files misc/libemos misc/libemos/files To: Adriaan de Groot Cc: Po-Chuan Hsieh , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4684Cw1g1rz45RZ X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=adamw-org.20150623.gappssmtp.com header.s=20150623 header.b=Xs486nbO; dmarc=none; spf=pass (mx1.freebsd.org: domain of adamw@adamw.org designates 2a00:1450:4864:20::341 as permitted sender) smtp.mailfrom=adamw@adamw.org X-Spamd-Result: default: False [-3.94 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[adamw-org.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-ports-all@freebsd.org]; DMARC_NA(0.00)[adamw.org]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[adamw-org.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; RCVD_IN_DNSWL_NONE(0.00)[1.4.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-0.45)[ip: (3.20), ipnet: 2a00:1450::/32(-3.03), asn: 15169(-2.39), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 22:35:25 -0000 On Wed, Aug 14, 2019 at 3:28 PM Adriaan de Groot wrote: > > [[ Also BCC-ing some people who reported this separately. ]] > > On Wednesday, 14 August 2019 19:32:54 CEST Po-Chuan Hsieh wrote: > > > +%%DATADIR%%/Help/release/%%PYTHON_VER%%.rst > > > > This change is incorrect. > > And it breaks packaging for people not using Python 3.6 as default version. > > Your -- Po-Chuan Hsieh -- comment is entirely correct. That was a bad change > to the plist, and I'd like to thank adamw for stepping in and fixing it in > r508973. This is one of those unexpected replacements inserted into plists > when (re)generating them. I don't know how to express "not every 3.6 is a > PYTHON_VER" though to the tooling :( > > Something to keep checking in the future, I'll add it to the post-it. It's a catch-22. Some plists are way too difficult to update manually between releases, but the likelihood of error increases with size. Furthermore, you only get accurate and complete plists when all relevant options are enabled, which necessarily increases the size of the substitution set. I have a small script of sanity checks that I run before committing. One of them contains something like this (from memory; I don't have it in front of me): svn diff pkg-plist | grep '^\+.*/.*%%' The idea is to flag all the new lines that use plist substitutions anywhere except at the beginning. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org