From owner-svn-src-head@FreeBSD.ORG  Mon Jan  5 20:15:32 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B9917106566C
	for <svn-src-head@freebsd.org>; Mon,  5 Jan 2009 20:15:32 +0000 (UTC)
	(envelope-from christoph.mallon@gmx.de)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20])
	by mx1.freebsd.org (Postfix) with SMTP id EFA498FC19
	for <svn-src-head@freebsd.org>; Mon,  5 Jan 2009 20:15:31 +0000 (UTC)
	(envelope-from christoph.mallon@gmx.de)
Received: (qmail invoked by alias); 05 Jan 2009 20:15:30 -0000
Received: from p54A3E58D.dip.t-dialin.net (EHLO tron.homeunix.org)
	[84.163.229.141]
	by mail.gmx.net (mp001) with SMTP; 05 Jan 2009 21:15:30 +0100
X-Authenticated: #1673122
X-Provags-ID: V01U2FsdGVkX1+T8dxRKVeTwa01BXZql77v1sMZBOgB9uswM+Lsz2
	2c35lbgS/TdRm6
Message-ID: <49626A60.70808@gmx.de>
Date: Mon, 05 Jan 2009 21:15:28 +0100
From: Christoph Mallon <christoph.mallon@gmx.de>
User-Agent: Thunderbird 2.0.0.19 (X11/20090103)
MIME-Version: 1.0
To: "Bjoern A. Zeeb" <bz@FreeBSD.org>
References: <200901042153.n04LrgkD075147@svn.freebsd.org>	<20090104220716.GL14235@hoeg.nl>	<alpine.BSF.2.00.0901042213530.67103@fledge.watson.org>	<20090105172400.T45399@maildrop.int.zabbadoz.net>	<49624DB9.8080900@gmx.de>
	<20090105194210.P45399@maildrop.int.zabbadoz.net>
In-Reply-To: <20090105194210.P45399@maildrop.int.zabbadoz.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
X-FuHaFi: 0.59
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r186751 - in head/sys: netinet6 netipsec
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jan 2009 20:15:33 -0000

Bjoern A. Zeeb schrieb:
> On Mon, 5 Jan 2009, Christoph Mallon wrote:
>> Bjoern A. Zeeb schrieb:
>>> I have broken it out from a larger patch; the C99 initializer is here:
>>> http://people.freebsd.org/~bz/20090105-02-c99-initializers.diff
>>>
>>> I case someone can give it a quick glance I'll commit them.
>>
>> +    .pr_flags    = PR_ATOMIC|PR_ADDR,
>>
>> style(9) wants spaces around binary operators.
> 
> I am not sure it does.

"Unary operators do not require spaces, binary operators do."
I guess only "usual" binary operators are meant here and it does not 
include ",", "[]" or "->".

> In case it does I am not going to break
> consistency with all other 65 places that don't do for pr_flags;

You have a point there. Maybe these should be fixed all at once.

> but it seems I should change the <tab>=<space> to <space>=<tab>.

<tab> /after/ =? This sounds wrong to me.
(In general I think using <tab> for alignment is a bad idea and it 
should only be used for indentation)