Date: Sat, 19 Sep 2015 15:23:50 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: wenheping <wenheping2000@hotmail.com> Cc: heping wen <wen@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r397327 - head/textproc/utf8proc Message-ID: <20150919152350.GA91306@FreeBSD.org> In-Reply-To: <20150919151048.GA87589@FreeBSD.org> References: <201509191415.t8JEFZsv027725@repo.freebsd.org> <20150919143043.GA69287@FreeBSD.org> <BLU168-W1444CCE589B0B5C1E20C79AC580@phx.gbl> <20150919151048.GA87589@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 19, 2015 at 03:10:48PM +0000, Alexey Dokuchaev wrote: > On Sat, Sep 19, 2015 at 11:06:56PM +0800, wenheping wrote: > > > Guys, please bear in mind that Kato's patches often contain unrelated > > > changes and should always be reviewed thoroughly before applying. > > > > Sorry I do not agree with you this time. > > > > There are 5 lines in the PLIST_FILES example in Porter's Handbook, then > > I think 6 lines is acceptable. > > *sigh* (I'm not even going to point out that 6 > 5); your logic could be > OK for a new port, but things were already perfectly fine, so this change > was totally gratuitous and uncalled for. To elaborate further: commit log stated "Update to 1.3", that's all. Even if you did consider making any changes unrelated to actual version upgrade, they should've been mentioned in the log with adequate explanation why they were necessary or desired. This was not done, and this happens very often when Kato's PR get committed. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150919152350.GA91306>