From nobody Thu Jun 16 07:29:52 2022 X-Original-To: gecko@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DB02285813C for ; Thu, 16 Jun 2022 07:29:53 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LNv2T5cH1z3F5F for ; Thu, 16 Jun 2022 07:29:53 +0000 (UTC) (envelope-from bapt@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655364593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=Zdf5WUg9gNrow4lnRz339dvxn3OdK8dUVRHYRQu6UE4=; b=ToSpcRs4nH500BD3IfC079ataF/EcInz2yesWjWzOG9WtTcHD+USRGtWixf1y8lzzM8EGK bi9CCk4tMfu69HfRI4/l6zP4POZwOJrtveKy8NOOqwcf6IF8arkfJqJgEwroyVFgpYH+WF HxZ0XL8sbSkEWTIG1+uVzM6CiM60PAgxvD9DlpX5IEcK8lXNAGcFKhQ2g5UdorLEANFrn0 0EuDA49LAH9LkAUT5nVB7iFAJHy5+fXxgbKHDMrIu4nrpRF+2dsg6OEz+Ym5kbAHE2KSEL qFoUOVrZwgX179FL2AmCI5voHw7+V+S6aArkCFsMgf136MpUvrCPUJeW/T+Nvg== Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 88E8C2FDD6 for ; Thu, 16 Jun 2022 07:29:53 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id 259C2143237; Thu, 16 Jun 2022 09:29:52 +0200 (CEST) Date: Thu, 16 Jun 2022 09:29:52 +0200 From: Baptiste Daroussin To: gecko@FreeBSD.org Subject: Fix the restart button Message-ID: <20220616072952.o7jeeiswo6x5ftok@aniel.nours.eu> List-Id: Gecko Rendering Engine issues List-Archive: https://lists.freebsd.org/archives/freebsd-gecko List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gecko@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655364593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=Zdf5WUg9gNrow4lnRz339dvxn3OdK8dUVRHYRQu6UE4=; b=KRye8vosBdkuvjeP6zJGtniQTx5A0fT7aQW2BdW97Gv80f/1eJDVrzyknYZ0AEpsv01d+w aYbKQudZ9pfl11GOUeeWvzBK6D8LFIA0wIs0Q16sWHeJcyp9hm5Q9jO3lA8PthWz4M/zzZ 5VCFj/KsVGl5V9/4/Qux15/keEP40uPApxCRT6YYOwN7BZ4T/qXi9L33lKIfWL60XifkJg BO+3pnr+oDfXgEciLYBL6nN+Bk1uRbW2cIOYvouESOBLpExKCdWgTcE9MJKtoFesEMWBVr alAq+zVaR603e6ksJV23dHXrnw4D+MPEbPpzhmfgD8Kllmnd3D7fPncjNpMpKQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1655364593; a=rsa-sha256; cv=none; b=KHFutiD1SXp5fvFeN//oumCyq/1KM49WPtWG28IsqEKD8aa/u3bi/KOvEzjzWT1v4p8JD/ G42Tet5WtbXs1sn5aUou7+xzRPk0pe2YobbunC3gK4CaAGTw+G1RYr5O0CGucEXGO9FNIA WsOssakRrQb0GakxE2+6aPYS17fmcSehbQsqOVkLN0LubrkJTKFtGM79f18OKEFk4Nuj9M edm4L/tMfeCzBRy5h8rAfQOA6xmjo0uDa7sy3d0ZAKvY6isVQTmxpuM2cGhdXV/QuT8oEu 0zUziaEpsA5atXkqAzL5hUUMKK91E0Ar3fMq9tDefSX1AoaVxU4sP3z4O7GpLw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Hello, I have stolen this patch from OpenBSD, which was done to please pledge, but in the end fixes the restart button. https://bapt.nours.eu/patch-xpcom_build_BinaryPath.h If my investigation is right, firefox when one click on the restart button (in case of upgrade) will call for the sysctl KERN_PROC_PATHNAME, which will return en empty value, because the binary has been unlinked and replace by the new one. (the behaviour is different on linux here) but forcing the path at buildtime make it work reliably and at least here, it makes the restart button working reliably note that it needs a post-patch target to replace %%PREFIX%% in xpcom/build/BinaryPath.h file. Best regards, Bapt