From owner-freebsd-net@FreeBSD.ORG Wed May 7 08:05:07 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E91CE106567C for ; Wed, 7 May 2008 08:05:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id 9C3098FC15 for ; Wed, 7 May 2008 08:05:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id C8F8041C713; Wed, 7 May 2008 10:05:05 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id Y7qq+GXixUxV; Wed, 7 May 2008 10:05:05 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id 6664141C735; Wed, 7 May 2008 10:05:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 4762B44487F; Wed, 7 May 2008 08:04:12 +0000 (UTC) Date: Wed, 7 May 2008 08:04:12 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Julian Elischer In-Reply-To: <4820C8CE.8010309@elischer.org> Message-ID: <20080507074647.B47338@maildrop.int.zabbadoz.net> References: <4816D1D2.7010603@elischer.org> <20080506202940.K47338@maildrop.int.zabbadoz.net> <4820C8CE.8010309@elischer.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: FreeBSD Net Subject: Re: multiple routing tables review patch ready for simple testing. X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2008 08:05:08 -0000 On Tue, 6 May 2008, Julian Elischer wrote: Hi, > Bjoern A. Zeeb wrote: >> On Tue, 29 Apr 2008, Julian Elischer wrote: >> >> Hi, >> >>> The patch can be found at >>> http://www.freebsd.org/~julian/mrt.diff >>> (or http://www.freebsd.org/~julian/mrt6.diff for RELENG_6) >>> >>> or source can be taken from perforce at: >>> //depot/user/julian/routing/src >> >> So after looking at the patch a bit more again, could you add wrapper >> functions for those like you have done for the old KPI (rtrequest, >> rtrequest1, > > do you really want to do the extra work instructions? > ... >> >> The defines will not give you a stable KPI and having that changed again >> if you are going with a prefix for each AF would be a pain if the _fib >> versions >> are going to change in the future. > > hmm fair enough... but let me outline my plans and thoughts > so we can see if you still want this.. > [ ... ] > > This all however is not ABI compatible so could not go back to 7.x > and I want to check in an initial version that can go back to 7.x > which sort of suggests to me that adding in_xxx functions is > not really required, until I do the next step. > 7.x will never get the next step. because the ABI is already set > in stone for 7.x. > > I would make the in_xxx stubs in the next step in 8.x. > after the MFC to 7.x of the ABI compat version. > > > let me know what you think. Leaving aside any upcoming enhancement if what we have now is what is going into 7 and possibly 6 we should do the wrapper functions. The point is RELENG_7 will live for $(last release + 2 years) so I guess till 2011 or maybe later. No idea what would happen there in all that time. If people start adding support for other AFs we cannot say that the *_fib variants are not going to change so having the in_* stable sounds like a good thing for 6 and 7. Am I missing anything obvious? I don't mind if they are going to significantly change again in 8 a few weeks later. /bz -- Bjoern A. Zeeb Stop bit received. Insert coin for new game.