From owner-svn-src-head@freebsd.org Mon Oct 16 15:39:10 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02A8EE3D64C; Mon, 16 Oct 2017 15:39:10 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from fry.fubar.geek.nz (fry.fubar.geek.nz [139.59.165.16]) by mx1.freebsd.org (Postfix) with ESMTP id C0B1D101; Mon, 16 Oct 2017 15:39:09 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from dhcp-10-248-99-227.eduroam.wireless.private.cam.ac.uk (global-5-141.nat-2.net.cam.ac.uk [131.111.5.141]) by fry.fubar.geek.nz (Postfix) with ESMTPSA id 451414ECB2; Mon, 16 Oct 2017 15:38:38 +0000 (UTC) From: Andrew Turner Message-Id: Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader Date: Mon, 16 Oct 2017 16:38:37 +0100 In-Reply-To: Cc: eric@meatspace.com, src-committers , svn-src-head@freebsd.org, svn-src-all@freebsd.org, Warner Losh To: Warner Losh References: <201710160359.v9G3xCCi087576@repo.freebsd.org> X-Mailer: Apple Mail (2.3273) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 15:39:10 -0000 I have a local Jenkins setup that builds images & tries to run under = various simulators. The final image is built with mkimg. I=E2=80=99m = running it under qemu. Andrew > On 16 Oct 2017, at 13:19, Warner Losh wrote: >=20 > I'll take a look, but I've also ccd Eric so he can figure out what = went wrong with is code in your environment. What env is That? >=20 > Warnee >=20 > On Oct 16, 2017 3:26 AM, "Andrew Turner" > wrote: >=20 > > On 16 Oct 2017, at 04:59, Warner Losh wrote: > > > > Author: imp > > Date: Mon Oct 16 03:59:11 2017 > > New Revision: 324646 > > URL: https://svnweb.freebsd.org/changeset/base/324646 = > > > > Log: > > Unify boot1 with loader > > > > Refactor boot1 to use the same I/O code as /boot/loader uses. = Refactor > > to use the common efi_main.c. > > > > Submitted by: Eric McCorkle > > Differential Revision: https://reviews.freebsd.org/D10447 = > > > > Added: > > head/sys/boot/efi/libefi/efi_main.c (contents, props changed) > > - copied, changed from r324645, = head/sys/boot/efi/loader/efi_main.c > > Deleted: > > head/sys/boot/efi/boot1/boot_module.h > > head/sys/boot/efi/boot1/ufs_module.c > > head/sys/boot/efi/boot1/zfs_module.c > > head/sys/boot/efi/loader/efi_main.c > > Modified: > > head/sys/boot/efi/boot1/Makefile > > head/sys/boot/efi/boot1/boot1.c > > head/sys/boot/efi/libefi/Makefile > > head/sys/boot/efi/loader/Makefile >=20 > Hello Warner, >=20 > After this change I=E2=80=99m getting the following panic on various = test VMs. >=20 > Andrew >=20 > >> FreeBSD EFI boot block >=20 > Loader path: /boot/loader.efi >=20 > Load Path: \EFI\BOOT\BOOTAA64.EFI > Load Device: = VenHw(837DCA9E-E874-4D82-B29A-23FE0E23D1E2,003C000A00000000)/HD(1,GPT,DD40= E9C6-B247-11E7-AA0A-15EFE1BBB7CF,0x3,0x640) > panic: Couldn't trim device path > --> Press a key on the console to reboot <-- >=20