From nobody Wed Jan 18 11:18:29 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NxjtY5DDJz2svbL; Wed, 18 Jan 2023 11:18:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NxjtY4mJ5z49Lq; Wed, 18 Jan 2023 11:18:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674040709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C31LSDNqXwBraa1oESgbIXDzJjZ4ELQfOVFSqLDHa4Y=; b=nzINegJGFD5tUyIcawGdCmD0opHkLqVJC9nYtnTov/hxMKv477wlByfeKkxFBVL7ah5Y1P ROZcivfBJEOYVG9Ii6/x55VjKY5elvsrbGzJLtoTaSj2q+QJ46rQxo94d4eOfQX+uj9E/o S6yM1Q9OfUuZuQLI6GR5Nm9d+epHQskdLKTn6oJmOOhSXr1X7F3NmelxKJEp5orySiDnXG xCb5XG70bJahvygvxomKeJtDyzl+D2LuyhnI9VE6C67u/E3XGHPvJYJftUzBRAnA7WQwTR BzFtkv5rlB4z8lKD1UgWXY1Bu8nJGDl4iQg8BwrwLWVDltW6C01icsXQShbgJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674040709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C31LSDNqXwBraa1oESgbIXDzJjZ4ELQfOVFSqLDHa4Y=; b=G/dWpoWfgu2ypyflInNTCcX9nZNPQ2vHD9iU0YlCOthxLHzX7YaMU4AGBmcSSU0b5+ftSQ 6e86QiwYIajWZRWTOsTADlRypjgxKsiX937ZlGRcHlf2EuWbCx4jvW4qRNy4QK6iA6OG7V v59vyTB/Zalfqnjgf9lOYPQFNFRNY4bVSDWOiguj7W/CgVitAPZw/EzybFVwJ7gS/SM6DG cQReJf/RaLrRB6AbHjG0BrcLBM6fHNC5p5PIy2wiV1WfBe0/n938aJgQ3RN4qydWcAtxgC 0vWUN6OpozafIyCmSQS1MTfh+UNXJ1zVOIIW44CKu+zJiMJ6d9VgBz1lT6/byQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674040709; a=rsa-sha256; cv=none; b=QyeUnOXrHF0ALt6LcQlKh6381nOIQ1peU3HxPAALnCP2fwP4T/5B/ct9tKSsDurmPBqlHG dC+v3IlwBE62oYuBDWZUYqo2f0rSDybbP6HYv4glJm2phwHwQzDADsksnQdnQau5YgNpKR cV9lNcdq61xVaYqiJSFRT/iXdoPeW7WgS8/mJ/uaEEckutIf05R/uXHDVG7nHaE0OQFbkp bkjruuqUCEHYc1Jyws1HkHpf+TzxKlcRouFO45zBXt08hV67oaC8Ct+HbCMfTeowoe7g5q Oq46ip8VEgty8UeG10+KKGGT9W7vNkcFNVhRGXiboZ7KL0lQQeUPMnRPtdCxvg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NxjtY3prhz1840; Wed, 18 Jan 2023 11:18:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30IBITsH096267; Wed, 18 Jan 2023 11:18:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30IBIT1J096266; Wed, 18 Jan 2023 11:18:29 GMT (envelope-from git) Date: Wed, 18 Jan 2023 11:18:29 GMT Message-Id: <202301181118.30IBIT1J096266@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: =?utf-8?Q?Corvin=20K=C3=B6hne?= Subject: git: 73c3e8b1dee6 - main - umodem: add quirk to ignore CDC_CM descriptor List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: corvink X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 73c3e8b1dee6cd42de32287ea8a57762b961d8ee Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by corvink: URL: https://cgit.FreeBSD.org/src/commit/?id=73c3e8b1dee6cd42de32287ea8a57762b961d8ee commit 73c3e8b1dee6cd42de32287ea8a57762b961d8ee Author: Steffen Dirkwinkel AuthorDate: 2023-01-17 07:58:46 +0000 Commit: Corvin Köhne CommitDate: 2023-01-18 11:17:09 +0000 umodem: add quirk to ignore CDC_CM descriptor Some devices have CDC_CM descriptors that would point us to the wrong interfaces. Add a quirk to ignore those (prefering the CDC_UNION descriptor effectively) Reviewed by: manu MFC after: 1 week Sponsored by: Beckhoff Automation GmbH & Co. KG Differential Revision: https://reviews.freebsd.org/D37942 --- share/man/man4/usb_quirk.4 | 2 ++ sys/dev/usb/quirk/usb_quirk.c | 1 + sys/dev/usb/quirk/usb_quirk.h | 1 + sys/dev/usb/serial/umodem.c | 4 +++- 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/share/man/man4/usb_quirk.4 b/share/man/man4/usb_quirk.4 index c176993bdbc3..892c85aa6fba 100644 --- a/share/man/man4/usb_quirk.4 +++ b/share/man/man4/usb_quirk.4 @@ -100,6 +100,8 @@ select configuration index 4 by default select configuration index 0 by default .It UQ_ASSUME_CM_OVER_DATA assume cm over data feature +.It UQ_IGNORE_CDC_CM +ignore cm descriptor .It UQ_WMT_IGNORE device should be ignored by wmt driver .El diff --git a/sys/dev/usb/quirk/usb_quirk.c b/sys/dev/usb/quirk/usb_quirk.c index 68e4910202b0..3baa3acba187 100644 --- a/sys/dev/usb/quirk/usb_quirk.c +++ b/sys/dev/usb/quirk/usb_quirk.c @@ -662,6 +662,7 @@ static const char *usb_quirk_str[USB_QUIRK_MAX] = { [UQ_CFG_INDEX_4] = "UQ_CFG_INDEX_4", [UQ_CFG_INDEX_0] = "UQ_CFG_INDEX_0", [UQ_ASSUME_CM_OVER_DATA] = "UQ_ASSUME_CM_OVER_DATA", + [UQ_IGNORE_CDC_CM] = "UQ_IGNORE_CDC_CM", [UQ_MSC_NO_TEST_UNIT_READY] = "UQ_MSC_NO_TEST_UNIT_READY", [UQ_MSC_NO_RS_CLEAR_UA] = "UQ_MSC_NO_RS_CLEAR_UA", [UQ_MSC_NO_START_STOP] = "UQ_MSC_NO_START_STOP", diff --git a/sys/dev/usb/quirk/usb_quirk.h b/sys/dev/usb/quirk/usb_quirk.h index 85bec036f84d..755465576684 100644 --- a/sys/dev/usb/quirk/usb_quirk.h +++ b/sys/dev/usb/quirk/usb_quirk.h @@ -66,6 +66,7 @@ enum { UQ_CFG_INDEX_4, /* select configuration index 4 by default */ UQ_CFG_INDEX_0, /* select configuration index 0 by default */ UQ_ASSUME_CM_OVER_DATA, /* assume cm over data feature */ + UQ_IGNORE_CDC_CM, /* ignore cm descriptor */ /* * USB Mass Storage Quirks. See "storage/umass.c" for a diff --git a/sys/dev/usb/serial/umodem.c b/sys/dev/usb/serial/umodem.c index e9de2950fb9d..d059559bd39f 100644 --- a/sys/dev/usb/serial/umodem.c +++ b/sys/dev/usb/serial/umodem.c @@ -359,7 +359,9 @@ umodem_attach(device_t dev) /* get the data interface number */ - cmd = umodem_get_desc(uaa, UDESC_CS_INTERFACE, UDESCSUB_CDC_CM); + cmd = NULL; + if (!usb_test_quirk(uaa, UQ_IGNORE_CDC_CM)) + cmd = umodem_get_desc(uaa, UDESC_CS_INTERFACE, UDESCSUB_CDC_CM); if ((cmd == NULL) || (cmd->bLength < sizeof(*cmd))) { cud = usbd_find_descriptor(uaa->device, NULL,