From owner-svn-ports-all@FreeBSD.ORG  Sun Oct 28 21:24:00 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 12A55490;
 Sun, 28 Oct 2012 21:24:00 +0000 (UTC)
 (envelope-from bapt@FreeBSD.org)
Received: from freefall.freebsd.org (unknown [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id B91998FC12;
 Sun, 28 Oct 2012 21:23:59 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q9SLNxvP024719;
 Sun, 28 Oct 2012 21:23:59 GMT (envelope-from bapt@FreeBSD.org)
Received: (from bapt@localhost)
 by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q9SLNxIS024718;
 Sun, 28 Oct 2012 21:23:59 GMT (envelope-from bapt@FreeBSD.org)
X-Authentication-Warning: freefall.freebsd.org: bapt set sender to
 bapt@FreeBSD.org using -f
Date: Sun, 28 Oct 2012 22:23:56 +0100
From: Baptiste Daroussin <bapt@FreeBSD.org>
To: "Jason E. Hale" <jhale@FreeBSD.org>
Subject: Re: svn commit: r306571 - head/sysutils/mbmon
Message-ID: <20121028212355.GV18995@ithaqua.etoilebsd.net>
References: <201210282046.q9SKk6qR095693@svn.freebsd.org>
 <1663223.kWmZmHxpKG@mocha.verizon.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="ZUxj+kVYsk1YKJSS"
Content-Disposition: inline
In-Reply-To: <1663223.kWmZmHxpKG@mocha.verizon.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org,
 ports-committers@FreeBSD.org, Pawel Pekala <pawel@FreeBSD.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Oct 2012 21:24:00 -0000


--ZUxj+kVYsk1YKJSS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Oct 28, 2012 at 05:12:16PM -0400, Jason E. Hale wrote:
> On Sunday, October 28, 2012 20:46:06 Pawel Pekala wrote:
> > Author: pawel
> > Date: Sun Oct 28 20:46:06 2012
> > New Revision: 306571
> > URL: http://svn.freebsd.org/changeset/ports/306571
> >=20
> > Log:
> >   - Convert to OptionsNG [1]
> <--snip-->
> >=20
> > -OPTIONS=3D	SMB "enable smb(4) support" on
> > +OPTIONS_DEFINE=3D	ASUS SMB
> > +OPTIONS_SET=3D	SMB
> > +ASUS_DESC=3D	"Enable A7N8X-VM support"
> > +SMB_DESC=3D	"Enable smb(4) support"
> >=20
> Should be OPTIONS_DEFAULT rather than OPTIONS_SET.
>=20
> --=20
> Jason E. Hale - jhale@
> FreeBSD Ports Committer
> KDE/FreeBSD Team

OPTIONS_SET and OPTIONS_UNSET are for end user, so yes it should be
OPTIONS_DEFAULT here :)

regards,
Bapt

--ZUxj+kVYsk1YKJSS
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlCNomsACgkQ8kTtMUmk6EyxKwCgjBzFE5/0IheN8/C80zg6x83S
1U8AoKotgJVt3g43M/rUcOS2/CO/HWsZ
=zO8T
-----END PGP SIGNATURE-----

--ZUxj+kVYsk1YKJSS--