From owner-dev-commits-src-all@freebsd.org Mon Mar 22 14:37:30 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5FBBC5B0F5B; Mon, 22 Mar 2021 14:37:30 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F3xt22Bypz3lgP; Mon, 22 Mar 2021 14:37:30 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 38259A540; Mon, 22 Mar 2021 14:37:30 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f177.google.com with SMTP id g20so10716572qkk.1; Mon, 22 Mar 2021 07:37:30 -0700 (PDT) X-Gm-Message-State: AOAM531UZQszFi5zOeD1wxMKYddiwuTBVBjx9bEzwzi3C+h3/NWSu0rn KUvA3hmbTesg4UZnHF7vH3G8YjzcUKN9ZvucWAM= X-Google-Smtp-Source: ABdhPJw0+ihjKZhX/4uS2JKnB9rsIyE4/Pi7LnI/8Y2kt/7RONJDYTYuSX0NucLI9EnJB2hNZ1IiiVJE161dR3ho2YI= X-Received: by 2002:a37:de14:: with SMTP id h20mr372270qkj.34.1616423849681; Mon, 22 Mar 2021 07:37:29 -0700 (PDT) MIME-Version: 1.0 References: <202103221200.12MC0Rja055125@gitrepo.freebsd.org> In-Reply-To: <202103221200.12MC0Rja055125@gitrepo.freebsd.org> From: Kyle Evans Date: Mon, 22 Mar 2021 09:37:17 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 87d65c747a43 - main - lib/msun: Allow building tests with WARNS=6 To: Alex Richardson Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2021 14:37:30 -0000 On Mon, Mar 22, 2021 at 7:01 AM Alex Richardson wrote: > > The branch main has been updated by arichardson: > > URL: https://cgit.FreeBSD.org/src/commit/?id=87d65c747a4389901c2bbbcb1ec4878b2df7b32c > > commit 87d65c747a4389901c2bbbcb1ec4878b2df7b32c > Author: Alex Richardson > AuthorDate: 2021-02-25 14:28:17 +0000 > Commit: Alex Richardson > CommitDate: 2021-03-22 11:55:07 +0000 > > lib/msun: Allow building tests with WARNS=6 > > The only change needed is to mark a few variables as static. > --- > contrib/netbsd-tests/lib/libm/t_ldexp.c | 19 +++++++++---------- > contrib/netbsd-tests/lib/libm/t_precision.c | 4 ++-- > contrib/netbsd-tests/lib/libm/t_round.c | 2 +- > contrib/netbsd-tests/lib/libm/t_scalbn.c | 2 +- > lib/msun/tests/Makefile | 2 +- > 5 files changed, 14 insertions(+), 15 deletions(-) > > [... snip ...] > diff --git a/lib/msun/tests/Makefile b/lib/msun/tests/Makefile > index 309f49c6dddd..4ef25c0a909a 100644 > --- a/lib/msun/tests/Makefile > +++ b/lib/msun/tests/Makefile > @@ -88,7 +88,7 @@ SRCS.ilogb2_test= ilogb_test.c > > LIBADD+= m > > -WARNS?= 1 > +WARNS?= 6 > > # Copied from lib/msun/Makefile > .if ${MACHINE_CPUARCH} == "i386" Hi, IMO, we should go ahead and drop this WARNS entirely now that it's the default -- I changed it a while back so that all depths of userland should get a natural WARNS=6 if it's undefined. Thanks, Kyle Evans