From owner-freebsd-fs@freebsd.org  Thu Jun 25 18:29:11 2015
Return-Path: <owner-freebsd-fs@freebsd.org>
Delivered-To: freebsd-fs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A107D98C5C7
 for <freebsd-fs@mailman.ysv.freebsd.org>; Thu, 25 Jun 2015 18:29:11 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail107.syd.optusnet.com.au (mail107.syd.optusnet.com.au
 [211.29.132.53]) by mx1.freebsd.org (Postfix) with ESMTP id 631F21FDD
 for <freebsd-fs@freebsd.org>; Thu, 25 Jun 2015 18:29:11 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from c211-30-166-197.carlnfd1.nsw.optusnet.com.au
 (c211-30-166-197.carlnfd1.nsw.optusnet.com.au [211.30.166.197])
 by mail107.syd.optusnet.com.au (Postfix) with ESMTPS id BCEA7D43C1C;
 Fri, 26 Jun 2015 04:29:09 +1000 (AEST)
Date: Fri, 26 Jun 2015 04:29:07 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Mateusz Guzik <mjguzik@gmail.com>
cc: Konstantin Belousov <kostikbel@gmail.com>, freebsd-fs@freebsd.org
Subject: Re: atomic v_usecount and v_holdcnt
In-Reply-To: <20150625123156.GA29667@dft-labs.eu>
Message-ID: <20150626042546.Q2820@besplex.bde.org>
References: <20141122002812.GA32289@dft-labs.eu>
 <20141122092527.GT17068@kib.kiev.ua>
 <20141122211147.GA23623@dft-labs.eu> <20141124095251.GH17068@kib.kiev.ua>
 <20150314225226.GA15302@dft-labs.eu> <20150316094643.GZ2379@kib.kiev.ua>
 <20150317014412.GA10819@dft-labs.eu> <20150318104442.GS2379@kib.kiev.ua>
 <20150625123156.GA29667@dft-labs.eu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=XMDNMlVE c=1 sm=1 tr=0
 a=KA6XNC2GZCFrdESI5ZmdjQ==:117 a=PO7r1zJSAAAA:8 a=kj9zAlcOel0A:10
 a=JzwRw_2MAAAA:8 a=dfNNiiqOaOqD_QZmin8A:9 a=CjuIK1q_8ugA:10
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2015 18:29:11 -0000

On Thu, 25 Jun 2015, Mateusz Guzik wrote:

> On Wed, Mar 18, 2015 at 12:44:42PM +0200, Konstantin Belousov wrote:
>> On Tue, Mar 17, 2015 at 02:44:12AM +0100, Mateusz Guzik wrote:

>>> I replaced them with refcount_acquire_if_not_zero and
>>> refcount_release_if_not_last.
>> I dislike the length of the names.  Can you propose something shorter ?
>
> Unfortunately the original API is alreday quite verbose and I don't have
> anything readable which would retain "refcount_acquire" (instead of a
> "ref_get" or "ref_acq"). Adding "_nz" as a suffix does not look good
> ("refcount_acquire_if_nz").

refcount -> rc
acquire -> acq

The "acq" abbreviation is already used a lot for atomic ops.

Bruce