From owner-cvs-src@FreeBSD.ORG Tue Aug 5 08:56:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D50137B401; Tue, 5 Aug 2003 08:56:02 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id ADAD543F75; Tue, 5 Aug 2003 08:56:01 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h75FtuQX079037; Tue, 5 Aug 2003 08:55:56 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h75FtsI7079036; Tue, 5 Aug 2003 08:55:54 -0700 (PDT) Date: Tue, 5 Aug 2003 08:55:54 -0700 From: "David O'Brien" To: Diomidis Spinellis Message-ID: <20030805155554.GA95218@dragon.nuxi.com> References: <200308050722.h757MCxl098780@repoman.freebsd.org> <20030805122815.GA17099@numeri.campus.luth.se> <3F2FAE21.6EEB6309@aueb.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F2FAE21.6EEB6309@aueb.gr> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.1-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Diomidis Spinellis cc: Johan Karlsson Subject: Re: cvs commit: src/sys/dev/sym sym_fw.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2003 15:56:03 -0000 On Tue, Aug 05, 2003 at 04:16:17PM +0300, Diomidis Spinellis wrote: > > > Log: > > > Remove extraneous semicolons. They are already provided by > > > the macro definition, and cause the generation of syntactically > > > incorrect code that gcc happens to accept. > > > > This is backwards. > > >From style(9): > > Any final statement-ter- > > minating semicolon should be supplied by the macro invocation rather than > > the macro, to make parsing easier for pretty-printers and editors. > > > > Please consider reverting this and change the macros in the file to not > > supply the terminating semicolon. > > I would certainly follow the style(9) guide if the existing code allowed > it. Please realize that this driver is shared with other OS's.