Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 29 Sep 2018 18:59:24 +0000 (UTC)
From:      Jan Beich <jbeich@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org
Subject:   svn commit: r480913 - branches/2018Q3/www/firefox
Message-ID:  <201809291859.w8TIxOjS066571@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jbeich
Date: Sat Sep 29 18:59:24 2018
New Revision: 480913
URL: https://svnweb.freebsd.org/changeset/ports/480913

Log:
  MFH: r480912
  
  gecko: whitelist where DTRACE is enabled by default
  
  Userland probes are only supported on Tier1 architectures. Even though
  powerpc* should support dtrace -G may crash on C++ files built by GCC.
  DTRACE option is still exposed as long as dtrace(1) binary is present
  for easier debugging of libdtrace.
  
  PR:		221641 224271
  Approved by:	ports-secteam blanket

Modified:
  branches/2018Q3/www/firefox/Makefile.options
Directory Properties:
  branches/2018Q3/   (props changed)

Modified: branches/2018Q3/www/firefox/Makefile.options
==============================================================================
--- branches/2018Q3/www/firefox/Makefile.options	Sat Sep 29 18:58:11 2018	(r480912)
+++ branches/2018Q3/www/firefox/Makefile.options	Sat Sep 29 18:59:24 2018	(r480913)
@@ -4,7 +4,7 @@ OPTIONS_DEFINE+= 	BUNDLED_CAIRO CANBERRA DBUS DEBUG DT
 			INTEGER_SAMPLES LIBPROXY \
 			OPTIMIZED_CFLAGS PROFILE TEST
 
-OPTIONS_DEFAULT+=	DBUS DTRACE FFMPEG GCONF OPTIMIZED_CFLAGS PROFILE \
+OPTIONS_DEFAULT+=	DBUS FFMPEG GCONF OPTIMIZED_CFLAGS PROFILE \
 			${OPTIONS_MULTI_AUDIO:NSNDIO} \
 			${MACHINE_CPU:Msoftfp:C/.+/INTEGER_SAMPLES/}
 
@@ -19,8 +19,11 @@ JACK_IMPLIES=		ALSA
 OPTIONS_EXCLUDE+=	DTRACE
 .endif
 
-# ld(1) fails to link probes: Relocations in generic ELF (EM: 0)
-OPTIONS_EXCLUDE_aarch64=	DTRACE
+# opensolaris/lib/libdtrace/common/dt_link.c:
+#   <arch> not implemented
+#   failed to allocate space for probe
+OPTIONS_DEFAULT_amd64+=	DTRACE
+OPTIONS_DEFAULT_i386+=	DTRACE
 
 BUNDLED_CAIRO_DESC?=	Use bundled fork of cairo-1.9.5
 CANBERRA_DESC?=		Sound theme alerts



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809291859.w8TIxOjS066571>