From owner-freebsd-gnome@FreeBSD.ORG Mon Feb 20 14:44:27 2006 Return-Path: X-Original-To: freebsd-gnome@freebsd.org Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D795316A420 for ; Mon, 20 Feb 2006 14:44:27 +0000 (GMT) (envelope-from babak@farrokhi.net) Received: from royalway.propagation.net (royalway.propagation.net [66.221.228.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B50A43D46 for ; Mon, 20 Feb 2006 14:44:27 +0000 (GMT) (envelope-from babak@farrokhi.net) Received: from localhost (localhost [127.0.0.1]) by royalway.propagation.net (Postfix) with ESMTP id 2E08256423 for ; Mon, 20 Feb 2006 08:44:27 -0600 (CST) Received: from royalway.propagation.net ([127.0.0.1]) by localhost (royalway.propagation.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 20770-04 for ; Mon, 20 Feb 2006 08:44:21 -0600 (CST) Received: from ELF (unknown [217.24.159.130]) by royalway.propagation.net (Postfix) with ESMTP id A77AC56422 for ; Mon, 20 Feb 2006 08:44:19 -0600 (CST) From: "Babak Farrokhi" To: Date: Mon, 20 Feb 2006 18:14:14 +0330 Message-ID: <001101c6362c$21b97120$eb0ba8c0@ELF> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2670 Thread-Index: AcY2LB6FkeVTJpUeSTq3jEv4a3PyhQ== X-Virus-Scanned: amavisd-new at farrokhi.net Subject: WITHOUT_DEBUG flag for x11-toolkits/gtk20 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Feb 2006 14:44:28 -0000 Folks, I have always been wondering why this port does not support standard WITHOUT_DEBUG flag (as many ports support this flag, and once you set WITH_DEBUG=no in /etc/make.conf, those ports while enable debugging instead!). So I just added this simple modification to the Makefile to honor the WITHOUT_DEBUG knob. (I am not sure, maybe there was a good reason for using WITH_DEBUG instead of WITHOUT_DEBUG). --- gtk20.patch begins here --- diff -ruN gtk20.orig/Makefile gtk20/Makefile --- gtk20.orig/Makefile Mon Feb 20 17:48:23 2006 +++ gtk20/Makefile Mon Feb 20 17:52:25 2006 @@ -51,6 +51,11 @@ # on the command-line. # Set to minimum if you want to send in a backtrace; set # to yes if you want to know what gtk thinks it's doing. +.if defined(WITHOUT_DEBUG) +.if ${WITHOUT_DEBUG:L} == "yes" +WITH_DEBUG= no +.endif +.endif .if defined(WITH_DEBUG) .if ${WITH_DEBUG:L} == "no" CONFIGURE_ARGS+= --enable-debug=no --- gtk20.patch ends here --- Any opinions? -- Babak Farrokhi babak@farrokhi.net