From nobody Thu Jul 30 22:32:22 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hB3qB28Jjz6nC9R for ; Thu, 30 Jul 2026 22:32:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hB3qB19Pxz3WSh for ; Thu, 30 Jul 2026 22:32:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785450742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qK2PxDEqvOecvLUnVMSb+Nkup9Ls021iovTmu/lJ9PU=; b=nIIjnghnnnQiMSQ2A6sMLdMmRaVoogdo2Vsn2SSLUJ7ymsL7IxXZmFrG6+qRmENcO9GtvQ EaohdJZxpEAryeRrEwKKDQN0J16/u6mySPD1lixLENHPQSEYdvkd/nQMQ3QZLA3dmAZUSV vxQ9BUA/FhgNA7TqXywoIelOVtPBPIehOanBKMGSAoq2vxOuchM2i/xDLAe6bmTxjDaOaO 43u7U2ajOjvyMwGK/5twyaH5BRGSMo7HHjepjfyMYKK4VYNrHjNA4UxjkuhhUIN/sCXgXY Pdgl9ehFWuujiRWuKAMDjDfUnaGdYl2FkJTeFFajdxt9fX9OIzqIFsBklxrZYg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785450742; a=rsa-sha256; cv=none; b=CaJwTwtazhPBDnLbvzvim0kQFCsYX8/z8ea6Ryq46M0BCKF7Aj7xYYyNgooHSAhs7AOXGe zgSGS3y3x7cGWcTo2JOmoDNZHVs++M7pjkbbTTl82nTkAkRr0gtqTYTfcztGyX9FnVNLf0 aGUTFFqKhwsSlc4tiN3iK5n9tUdZ8mBEZxN1Gp9ac6vVQJQe4z/0m1Lb4zsjAuZ1MYqLch xocDm9qNxYkcRPdqMc6YzVcjMV/jK7jrbXOrdY4MMgAIGlzqk6a9I3GnT56CqJsOvx5i2l r3VrbaYq4XB5JFMVEJnc12DfyG3YwVW4XClsq+t6hK6NZPzSAvtbm3TUfaCSJg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785450742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qK2PxDEqvOecvLUnVMSb+Nkup9Ls021iovTmu/lJ9PU=; b=t80tFot1uy/PHtfL+Wj00qQqaxTJkd12uRWp9ZHQno59NUe1Lp+B9g5++h8kSFhGjy+MkV qjnaBXk3vV2yG6QZwh83z9yI71dUF6ZOVcKeCTkkh8GImJ4THw+5fQY4dKZy/vFsZp50zL /2+4yggLlWUdJnChWnoYEJk1xfD05fyk12V76o1NfIL6fibFLZqTR0xIb5zi9NlfJch0SI 5qIFk3GqArcUqGnKRg3W/XHxj41Vpvq0qeb0+jd5LQdP4Xics+Abk7C6RaYQl/vRY/c+e0 PuOVKwNO7sNwtmNiHDAJjyoSF/Tl//sju/9agrhhf55M/ciJJ2CCtn3NJ06GCQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hB3qB06b8zYk2 for ; Thu, 30 Jul 2026 22:32:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 33091 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 30 Jul 2026 22:32:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Pouria Mousavizadeh Tehrani Subject: git: 491f8d06a97d - main - if_gre(4): Fix link state announcement in SIOCDIFPHYADDR List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 491f8d06a97ddea44857725537d1031f2d6a9889 Auto-Submitted: auto-generated Date: Thu, 30 Jul 2026 22:32:22 +0000 Message-Id: <6a6bd0f6.33091.20fbb4fe@gitrepo.freebsd.org> The branch main has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=491f8d06a97ddea44857725537d1031f2d6a9889 commit 491f8d06a97ddea44857725537d1031f2d6a9889 Author: Pouria Mousavizadeh Tehrani AuthorDate: 2026-07-30 22:22:54 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-07-30 22:31:24 +0000 if_gre(4): Fix link state announcement in SIOCDIFPHYADDR Since we unlock gre before if_detach() and use slock in gre_clone_modify_nl() there is no need to split if_link_state_change() out of gre_delete_tunnel(). Reported by: markj Fixes: a0d2e5ebaa2e ("if_gre(4): Fix races by changing initialization order and locks") --- sys/net/if_gre.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/net/if_gre.c b/sys/net/if_gre.c index 1dc82238c6ab..4f97371148f0 100644 --- a/sys/net/if_gre.c +++ b/sys/net/if_gre.c @@ -405,7 +405,6 @@ gre_reassign(struct ifnet *ifp, struct vnet *new_vnet __unused, if (sc != NULL) gre_delete_tunnel(sc); sx_xunlock(&gre_ioctl_sx); - if_link_state_change(ifp, LINK_STATE_DOWN); } #endif /* VIMAGE */ @@ -419,7 +418,6 @@ gre_clone_destroy(struct if_clone *ifc, struct ifnet *ifp, uint32_t flags) gre_delete_tunnel(sc); ifp->if_softc = NULL; sx_xunlock(&gre_ioctl_sx); - if_link_state_change(GRE2IFP(sc), LINK_STATE_DOWN); bpfdetach(ifp); if_detach(ifp); @@ -662,6 +660,7 @@ gre_delete_tunnel(struct gre_softc *sc) sc->gre_so = NULL; } GRE2IFP(sc)->if_drv_flags &= ~IFF_DRV_RUNNING; + if_link_state_change(GRE2IFP(sc), LINK_STATE_DOWN); } struct gre_list *