From owner-freebsd-scsi Tue Feb 4 03:33:15 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id DAA11224 for freebsd-scsi-outgoing; Tue, 4 Feb 1997 03:33:15 -0800 (PST) Received: from sovcom.kiae.su (sovcom.kiae.su [193.125.152.1]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id DAA11215; Tue, 4 Feb 1997 03:33:04 -0800 (PST) Received: by sovcom.kiae.su id AA16535 (5.65.kiae-1 ); Tue, 4 Feb 1997 14:01:39 +0300 Received: by sovcom.KIAE.su (UUMAIL/2.0); Tue, 4 Feb 97 14:01:38 +0300 Received: (from ache@localhost) by nagual.ru (8.8.5/8.8.5) id OAA02105; Tue, 4 Feb 1997 14:00:47 +0300 (MSK) Date: Tue, 4 Feb 1997 14:00:44 +0300 (MSK) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: wpaul@freebsd.org, FreeBSD-current , FreeBSD-SCSI List Subject: Nice SCSI probe diagnostic is very broken for other cases Message-Id: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-scsi@freebsd.org X-Loop: FreeBSD.org Precedence: bulk Bill, you better restore sc_print_addr() to old variant and make new variant of this function especially for probe stage printing. With your changes I have sd0: Direct-Access 516MB (1057616 512 byte sectors)sd0 at scbus0 target 0 lun 0: with 2740 cyls, 4 heads, and an average 96 sectors/track ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ sc_print_addr output Moreover, many error diagnostics call sc_print_addr at the beginnig, so now some scsi error will looks like sd0 at scbus0 target 0 lun 0: cannot allocate scsi xs ^ this part can be MUCH longer for some cases What looks nice for probe stage looks very ugly for error messages. Please fix it. -- Andrey A. Chernov http://www.nagual.ru/~ache/