Date: Sat, 04 Oct 2008 12:45:43 -0400 From: Robert Noland <rnoland@2hip.net> To: freebsd-x11 <freebsd-x11@freebsd.org> Subject: Re: drm MSI support Message-ID: <1223138743.1619.35.camel@wombat.2hip.net> In-Reply-To: <1223134762.1619.32.camel@wombat.2hip.net> References: <1223134762.1619.32.camel@wombat.2hip.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sat, 2008-10-04 at 11:39 -0400, Robert Noland wrote: > I would like to get some initial feedback on this patch. It enables MSI > on capable cards. (I'm using it on my i965gm) The guys at Intel have > done this in the Linux driver. I have implemented it in our > infrastructure code which means that we will enable it on any hardware > that reports capable. The Intel guys have explicitly blacklisted a > couple of 945 class devices, stating that they report capable but don't > appear to work. While I would like to get verification that these chips > don't work, don't be surprised if it doesn't work if you have chips 2772 > or 27a2. I have not implemented the blacklist bits yet. > > The Linux crew has never enabled MSI on radeon hardware, though several > devices appear to report capable. When I inquired as to why they hadn't > done so, they just stated that they hadn't gotten around to it. I'm > particularly interested to see how this works on radeons. > > In order to use this patch, you need to be running CURRENT as I had to > make a few other changes to vgapci to get this working. You can see if > you hardware is capable by running pciconf -lvc. You will see something > like this: CURRENT needs to be at least: r183194 | rnoland | 2008-09-19 15:11:35 -0400 (Fri, 19 Sep 2008) | 6 lines pci_setup_intr() will only enable MSI/MSI-X for direct children. Add methods to vga_pci.c to request on behalf of it's children. This causes vgapci to show up as the interrupt owner in vmstat -i, rather than the child device. Approved by: jhb(mentor) robert. > vgapci0@pci0:0:2:0: class=0x030000 card=0x01f91028 chip=0x2a028086 > rev=0x0c hdr=0x00 > vendor = 'Intel Corporation' > device = 'Mobile 965 Express Integrated Graphics Controller' > class = display > subclass = VGA > cap 05[90] = MSI supports 1 message > cap 01[d0] = powerspec 3 supports D0 D3 current D0 > > When drm loads it will also report that it has enabled MSI. > > Please send me reports of what chips do/don't work. > > The patch is located at: > > http://people.freebsd.org/~rnoland/drm-msi.patch > > robert. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEABECAAYFAkjnnbcACgkQM4TrQ4qfROOU4ACeMHVRPWz69q95j0CGFRsCjGwE RF8AnRdgO0qBaOnCaQKKbGlZ6fDm5HCo =ExEn -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1223138743.1619.35.camel>