From owner-freebsd-emulation@freebsd.org Thu Sep 28 23:50:29 2017 Return-Path: Delivered-To: freebsd-emulation@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14D76E0F4C1 for ; Thu, 28 Sep 2017 23:50:29 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id E4DA4725ED for ; Thu, 28 Sep 2017 23:50:28 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id E421FE0F4BF; Thu, 28 Sep 2017 23:50:28 +0000 (UTC) Delivered-To: emulation@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3A72E0F4BE for ; Thu, 28 Sep 2017 23:50:28 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B4FCB725EC for ; Thu, 28 Sep 2017 23:50:28 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: by freefall.freebsd.org (Postfix) id 193D0135C; Thu, 28 Sep 2017 23:50:28 +0000 (UTC) Delivered-To: vbox@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id CC5DA135B for ; Thu, 28 Sep 2017 23:50:27 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) by mx1.freebsd.org (Postfix) with ESMTP id AD62D725EB; Thu, 28 Sep 2017 23:50:26 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: Re: [virtualbox-ose] Build failure: global register variable To: soralx@cydem.org Cc: vbox@FreeBSD.org References: <20170917195419.431341e7@mscad14> <20170920191710.58d335df@mscad14> <20170921160000.689755f8@mscad14> <5c68323f-5fed-342b-ad92-e74d178f9daf@FreeBSD.org> <20170924180619.23e149be@mscad14> <6b02f95f-207b-0f55-8e30-11512979804e@FreeBSD.org> <20170928025555.032ce67a@mscad14> From: Jung-uk Kim Message-ID: Date: Thu, 28 Sep 2017 19:50:15 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170928025555.032ce67a@mscad14> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1UBG38NjrWHRvO63BiPof6wcap2wO9Guf" X-Mailman-Approved-At: Fri, 29 Sep 2017 00:17:52 +0000 X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 23:50:29 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1UBG38NjrWHRvO63BiPof6wcap2wO9Guf Content-Type: multipart/mixed; boundary="xAN9aAOwPlXc2xqgf3bV9s5HwerH1lOGP"; protected-headers="v1" From: Jung-uk Kim To: soralx@cydem.org Cc: vbox@FreeBSD.org Message-ID: Subject: Re: [virtualbox-ose] Build failure: global register variable References: <20170917195419.431341e7@mscad14> <20170920191710.58d335df@mscad14> <20170921160000.689755f8@mscad14> <5c68323f-5fed-342b-ad92-e74d178f9daf@FreeBSD.org> <20170924180619.23e149be@mscad14> <6b02f95f-207b-0f55-8e30-11512979804e@FreeBSD.org> <20170928025555.032ce67a@mscad14> In-Reply-To: <20170928025555.032ce67a@mscad14> --xAN9aAOwPlXc2xqgf3bV9s5HwerH1lOGP Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 09/28/2017 05:55, soralx@cydem.org wrote: >=20 > Jung-uk, >=20 >>>>> [0] clang/lib/Basic/Targets/X86.h: >>>>> 860 bool validateGlobalRegisterVariable(StringRef RegName, >>>>> unsigned RegSize, 861 bool >>>>> &HasSizeMismatch) const override { 862 // rsp and rbp are the >>>>> only 64-bit registers the x86 backend can currently 863 // >>>>> handle. 864 if (RegName.equals("rsp") || RegName.equals("rbp"))= >>>>> { 865 // Check that the register size is 64-bit. >>>>> 866 HasSizeMismatch =3D RegSize !=3D 64; >>>>> 867 return true; >>>>> 868 } =20 >>>> >>>> Please try the attached patch. =20 >>> >>> Thanks for the patch! I gave it a quick try (not an extensive test), >>> and VirtualBox, compiled fully with clang, seems to work as usual. =20 >> >> Committed (r450636), thanks! >=20 > Sadly, I forgot to disable VT-x when testing. My bad. >=20 > I tested again, and found that, on unpatched VBox, the virtual > machine boots and works fine with both VT-x on and off, while > patched version fails to start the VM when VT-x is turned off: > VBoxManage: error: No error info > VBoxManage: error: Details: code NS_ERROR_CALL_FAILED (0x800706be), > component ProgressProxy, interface IProgress >=20 > How would one go about debugging this? Hmm... Unfortunately, I don't think we can "fix" it easily. I'll take a look but I just reverted it for now. Jung-uk Kim >> For more detailed information, please read the commit log. >> >> https://svnweb.freebsd.org/changeset/ports/45063 --xAN9aAOwPlXc2xqgf3bV9s5HwerH1lOGP-- --1UBG38NjrWHRvO63BiPof6wcap2wO9Guf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlnNisIACgkQfJ+WJvzb 8UZEKwgAmQX+EYQUzsYcCvH/FWriL+g1xnH4FZfclqDRuIE9Oi2XpmKO2KwXPYhW fTCOiu8oJukZsAs+XhLmtQyxtOYoWEkMChm3dU9HXMCtfZSlPwmHqKd4DcWWhqtP SlRz40iv+7TX9W6max93iRQdx2jLXzgPxoi44E8ptqzvl34kKcu40Q67oCrDep0C uQXzbEqFxyzPoS28deDC5Vcb321fTgMNW1KBlUC+aNgDrAJ9G+dCBoS5IyZmiksz l0q0LeWbikdEDdxUBILSGaOdGlTqDggHQA8k7oO5WpC0zXeYLK1/k5VpHKKbn7KU 3yg0ipXsw5fCrn6hPfm7XFPD07WCpA== =dh0z -----END PGP SIGNATURE----- --1UBG38NjrWHRvO63BiPof6wcap2wO9Guf--