From nobody Sat Jan 31 17:03:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f3K2H19vTz6QWhb for ; Sat, 31 Jan 2026 17:03:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f3K2G5tJkz3RSp for ; Sat, 31 Jan 2026 17:03:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769878982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TmcHyWt44/VaPZDfAXZ1uIoFkl5UcCF8495Ah8k0TZE=; b=igf0scbukBbmNMp23c0+prPVAngTUOvn7fFXzXbkqMHJKhLbzCmWRweLhjVGN8KfeQ/9Mi q3XLFxCsNqTU0M5DwusK+rh6ehP9hdKAIfMUV2a6SQBsxz2RrWf1BDGYNBhUHbPpIKcy/T 0tNZJD8g1jTRMiSkKYA83W6fc8xnDjo7VYjIfub+cspj8zES828YLYrU+1Mgv3+4Qo+v8K t7iUbxe43q4adLuB/ljnyUsrCpsgTW5ft3czf2t1XBtFvKux4Em2yyq056wcJ7/f/LyCN6 ZORokkvA6cEQAVaDs6/S0JTkCpn7M9aJN5LMIiGhlqhJih+ulZHUbZkztNUkgQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769878982; a=rsa-sha256; cv=none; b=PA1UvFREU1gYLAE8bYKiBA6YV2GUkm9tUEDESbT9zygsn7VBBO6k+IOjVv35PG7eWGZFCB S+q2jZcxl5t+vhOq429TUF/pIL4w6ModPycL6aUVCrjkUGIdyTjrFkGlrtCIDDYlRxJ7fi nZpE04cmzrs+mYlDxA1NvMyJoumYirCeZMsttKD5hviJJzknH0tuHJzvQg6cQLQ6Kapq0W LYcbBR7gfz7wG2lOC/WlB5j9FZwHVwpVYnGuJLjHSEM3H44TapaI9CVc96Mse+13g3JQsf PAEUhYBTPQToXHDlY0vHiFY7C95LHi76meXKo/4waamb0CHMsjZc6IVV/TYH5w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769878982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TmcHyWt44/VaPZDfAXZ1uIoFkl5UcCF8495Ah8k0TZE=; b=NCNuAx6jrpH9ZwGw396BkCqW2gc22DoYiWhJH0DeeUAMdobQgTHIa6Mu27076DhBnploui lToelOKYQGQiIklTcEeOComPeB+XJl0sT43+UOOK9RNE+G7CzfAZTfmOFypV9cDZFuDaL0 fzu/UbbD5LPRJPbFk0wG6Wau5ZcgBSqQmtTKcabS7U1yoDQlusC24IMZzK9VZB6eCVNUGZ m38qRAgXtzw2pW0Zgocn6vju2pi4WnKTH1GR8BbVvOOt/9ArLBuBdPfElzUGnM0EX4Nc+t VjbbR7fFiRYtx6V0zhWQfhXIx6M34bvSPY3/7LYt96HMvWB7cCMTBZl9AbxP7Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f3K2G5FYhz12fg for ; Sat, 31 Jan 2026 17:03:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19516 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 31 Jan 2026 17:03:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: b26a7af438f3 - main - heimdal: Pass the correct pointer to free in an error case List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b26a7af438f36dcde86f39a681123cc2140affb2 Auto-Submitted: auto-generated Date: Sat, 31 Jan 2026 17:03:02 +0000 Message-Id: <697e35c6.19516.42ccd72a@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=b26a7af438f36dcde86f39a681123cc2140affb2 commit b26a7af438f36dcde86f39a681123cc2140affb2 Author: John Baldwin AuthorDate: 2026-01-31 17:00:44 +0000 Commit: John Baldwin CommitDate: 2026-01-31 17:00:44 +0000 heimdal: Pass the correct pointer to free in an error case This fixes a warning reported by GCC 14 on stable/14: crypto/heimdal/lib/hdb/keys.c:241:13: warning: 'free' called on pointer 'ext' with nonzero offset 16 [-Wfree-nonheap-object] 241 | free(hist_keys); | ^~~~~~~~~~~~~~~ crypto/heimdal/lib/hdb/keys.c:234:15: note: returned from 'calloc' 234 | ext = calloc(1, sizeof (*ext)); | ^~~~~~~~~~~~~~~~~~~~~~~~ Reviewed by: rmacklem, cy Fixes: 5000d023a446 ("heimdal-kadmin: Add support for the -f dump option") Differential Revision: https://reviews.freebsd.org/D54932 --- crypto/heimdal/lib/hdb/keys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/lib/hdb/keys.c b/crypto/heimdal/lib/hdb/keys.c index 9c0af5c47f23..ef6113610009 100644 --- a/crypto/heimdal/lib/hdb/keys.c +++ b/crypto/heimdal/lib/hdb/keys.c @@ -238,7 +238,7 @@ hdb_add_current_keys_to_history(krb5_context context, hdb_entry *entry) hist_keys = &ext->data.u.hist_keys; hist_keys->val = calloc(1, sizeof (*hist_keys->val)); if (hist_keys->val == NULL) { - free(hist_keys); + free(ext); return ENOMEM; } hist_keys->len = 1;