From owner-freebsd-stable@freebsd.org Thu Apr 16 06:34:54 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 047AE2B24DC; Thu, 16 Apr 2020 06:34:54 +0000 (UTC) (envelope-from timp87@gmail.com) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 492qG46pXPz432X; Thu, 16 Apr 2020 06:34:52 +0000 (UTC) (envelope-from timp87@gmail.com) Received: by mail-wr1-x42c.google.com with SMTP id d27so3481431wra.1; Wed, 15 Apr 2020 23:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LPfmQUu0UfMQ1rR7YSThHDfoUkMef4LciOt0qUf53q0=; b=IGMb66aKbgpm5FADjd4DGNZX2t/fMKOXlSKQimI7jfve9Zx2NUeP96bnfm4eqsicLn L0ZoYANppc6Yagu6oHE1jvF3IX8EBNfpoQ4JFjs32KX5eXQR07ezuirVP63xaXapLijw 4fCT92PRh1lCcWtzOP3GRV4j4OaJe5WeNc/qLPMaIKhkM5q8ppTXMGLNkg53so9w8aCJ +YLsqBWGCCbYYJNoZF/G3z1WYpaNTpN6vAUk3Nix8FzU61kDks9oVGXuWKrYS9HXILAZ jOjOIUcDRHAjkvPO44cCS4jseowSq8MbiNwW0UCehgpyABL9RSeyOvI30U+gemI3uQsU nKWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LPfmQUu0UfMQ1rR7YSThHDfoUkMef4LciOt0qUf53q0=; b=GQEo/fV6jld56hvzViDnHOlU2L6mzp8NRopFEqJTs3EuR9kgC+RDmkAAEeTiKn9WCY OvSQr6g/4jwL5rHVsi8jutj1QOZ/IA/Q9S/k3CrBf7T++XtHVPlv3bioplfFoud1nIC6 mzpNJJvosRto03g7ugnMQjtGK7rdWmngdAS6+s2FHUsF8f/FV3djKQ83HV9Jxob3AupZ oNycaMBa0d7pBTwLrOM2zIOgLqcUBYe4jg9EmGkgp894kOTQE+4VfwsMqhbzYekkhSr+ 5wUOIlrCgGbZZTelXwu3sEmENOsOCceI84TP+ButRYknaS5z8CmRXd32jPmi64f/RkXw XB/g== X-Gm-Message-State: AGi0PuZx3IPGxSErdcc0zdIWuUbLCRLHBJwQ3MpuXj4UOh0kNs2gVtXI kOcgAs7JPuwP6E19SqLPzRWhXaNy2B1JP9Rp9Jfh9Q== X-Google-Smtp-Source: APiQypLCld7jAqOuX7lAP2nkn/81Spqa1jocBofXLPrTldVfhoS5zWO1HdPch1P1oLP21Jw658g7cAYrnY0t/SWKNJk= X-Received: by 2002:a5d:474b:: with SMTP id o11mr25202855wrs.391.1587018890418; Wed, 15 Apr 2020 23:34:50 -0700 (PDT) MIME-Version: 1.0 References: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> In-Reply-To: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> From: Pavel Timofeev Date: Thu, 16 Apr 2020 09:34:41 +0300 Message-ID: Subject: Re: CFT: if_bridge performance improvements To: Kristof Provost Cc: freebsd-current , freebsd-stable stable X-Rspamd-Queue-Id: 492qG46pXPz432X X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=IGMb66aK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of timp87@gmail.com designates 2a00:1450:4864:20::42c as permitted sender) smtp.mailfrom=timp87@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; URI_COUNT_ODD(1.00)[9]; IP_SCORE(0.00)[ip: (-9.12), ipnet: 2a00:1450::/32(-2.35), asn: 15169(-0.43), country: US(-0.05)]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[c.2.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 06:34:54 -0000 =D0=B2=D1=82, 14 =D0=B0=D0=BF=D1=80. 2020 =D0=B3., 12:51 Kristof Provost : > Hi, > > Thanks to support from The FreeBSD Foundation I=E2=80=99ve been able to w= ork > on improving the throughput of if_bridge. > It changes the (data path) locking to use the NET_EPOCH infrastructure. > Benchmarking shows substantial improvements (x5 in test setups). > > This work is ready for wider testing now. > > It=E2=80=99s under review here: https://reviews.freebsd.org/D24250 > > Patch for CURRENT: https://reviews.freebsd.org/D24250?download=3Dtrue > Patches for stable/12: > https://people.freebsd.org/~kp/if_bridge/stable_12/ > > I=E2=80=99m not currently aware of any panics or issues resulting from th= ese > patches. > > Do note that if you run a Bhyve + tap on bridges setup the tap code > suffers from a similar bottleneck and you will likely not see major > improvements in single VM to host throughput. I would expect, but have > not tested, improvements in overall throughput (i.e. when multiple VMs > send traffic at the same time). > > Best regards, > Kristof > Hi! Thank you for your work! Do you know if epair suffers from the same issue as tap? >