From owner-svn-src-head@freebsd.org  Tue Apr 17 15:30:56 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0145CF83F1E
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Tue, 17 Apr 2018 15:30:56 +0000 (UTC)
 (envelope-from ram.vegesna@broadcom.com)
Received: from mail-lf0-x231.google.com (mail-lf0-x231.google.com
 [IPv6:2a00:1450:4010:c07::231])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5789B68551
 for <svn-src-head@freebsd.org>; Tue, 17 Apr 2018 15:30:55 +0000 (UTC)
 (envelope-from ram.vegesna@broadcom.com)
Received: by mail-lf0-x231.google.com with SMTP id r7-v6so20863340lfr.1
 for <svn-src-head@freebsd.org>; Tue, 17 Apr 2018 08:30:55 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=qqy5m6I7x4BzoeoU3YEaXxk3tPlhW+o/SOhUDn+SOko=;
 b=BAHA9LCBDa0vtUEVpSRPeCy9IxjYOMMKppnldK1N3t/B+P35rORqHe6VZzVLI/NdzO
 J8g7sAEdU3dmRhClkiMPz3TmJrnSxeNBZCO/u2IBgKKkqMkK8VUOXuqwsntc/cyuO7rT
 kzqZFpLU1SCB5lFwGcqhS7e14f4DtJPuRKRjockKTNSbt24N3UAi/+0midwYP3KZCpgy
 BLn+rEfV5bYsRd1Fj/1tCOqwy2LfFsKfy7/hBKmUGlym1Q5Qdd5gV/VzO61NqFYRvRJF
 JcrjtHu3OCMnnDdIAP2nhQn2Gfe6fsbgMAOuEo8DuekpznqjI323EkEGcpbV0V23y7Js
 GdnQ==
X-Gm-Message-State: ALQs6tDHrI4dySR0PDyH3ODzYoVAN+n7O1vKo96AB6paXk0NyVd/PvfT
 EZBk8U3JoqR5vFpHaj+GnFxDQDIXECurEDlHp9Tz+A==
X-Google-Smtp-Source: AIpwx4/0iwow87UUeBMSEEvT/8ywSBHINslb2PX+iTfBE39uNGGBPfi4/80Oi1SV4geXfzeWyJ8b3feqxbVlrT8ZMBw=
X-Received: by 2002:a19:9b08:: with SMTP id d8-v6mr2053218lfe.66.1523979053708; 
 Tue, 17 Apr 2018 08:30:53 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.46.134.205 with HTTP; Tue, 17 Apr 2018 08:30:53 -0700 (PDT)
In-Reply-To: <CAPQ4ffu09YgGg5cVrQbFF5QYtkH0ASt1xZQtj5j0Y+_K1oWaaA@mail.gmail.com>
References: <201804131331.w3DDVKod044086@repo.freebsd.org>
 <CAPQ4ffu09YgGg5cVrQbFF5QYtkH0ASt1xZQtj5j0Y+_K1oWaaA@mail.gmail.com>
From: Ram Kishore Vegesna <ram.vegesna@broadcom.com>
Date: Tue, 17 Apr 2018 21:00:53 +0530
Message-ID: <CAF7aS0rr2CwCM9sX=iOHv7T2BBZQ7124s711XUiWDaq-MWxUvw@mail.gmail.com>
Subject: Re: svn commit: r332471 - head/sys/dev/ocs_fc
To: Oliver Pinter <oliver.pinter@hardenedbsd.org>
Cc: Ram Kishore Vegesna <ram@freebsd.org>, 
 "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 Bruce Evans <bde@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.25
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Apr 2018 15:30:56 -0000

Thanks Oliver, For pointing the issue. Checked in the change.

-Ram

On Sat, Apr 14, 2018 at 3:32 AM, Oliver Pinter <
oliver.pinter@hardenedbsd.org> wrote:

>
>
> On Friday, April 13, 2018, Ram Kishore Vegesna <ram@freebsd.org> wrote:
>
>> Author: ram
>> Date: Fri Apr 13 13:31:20 2018
>> New Revision: 332471
>> URL: https://svnweb.freebsd.org/changeset/base/332471
>>
>> Log:
>>   Check if STACK is defined before using the stack(9).
>>
>>   PR: 227446
>>   Reported by: emaste
>>   Approved by: ken
>>
>> Modified:
>>   head/sys/dev/ocs_fc/ocs_os.c
>>
>> Modified: head/sys/dev/ocs_fc/ocs_os.c
>> ============================================================
>> ==================
>> --- head/sys/dev/ocs_fc/ocs_os.c        Fri Apr 13 13:23:31 2018
>> (r332470)
>> +++ head/sys/dev/ocs_fc/ocs_os.c        Fri Apr 13 13:31:20 2018
>> (r332471)
>> @@ -37,6 +37,7 @@
>>   */
>>
>>  #include "ocs.h"
>> +#include "opt_stack.h"
>
>
> These types of includes - where you includes opts - should go before any
> other includes.
>
>
>
>>  #include <sys/sysctl.h>
>>  #include <sys/malloc.h>
>>  #include <sys/linker.h>                /* for debug of memory
>> allocations */
>> @@ -855,11 +856,13 @@ void ocs_intr_enable(ocs_os_handle_t os)
>>
>>  void ocs_print_stack(void)
>>  {
>> +#if defined(STACK)
>>         struct stack st;
>>
>>         stack_zero(&st);
>>         stack_save(&st);
>>         stack_print(&st);
>> +#endif
>>  }
>>
>>  void ocs_abort(void)
>> _______________________________________________
>> svn-src-head@freebsd.org mailing list
>> https://lists.freebsd.org/mailman/listinfo/svn-src-head
>> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"
>>
>