From owner-svn-src-all@freebsd.org Tue Sep 3 14:06:23 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5C75DDC2C2; Tue, 3 Sep 2019 14:06:04 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7yz4HPnz4P87; Tue, 3 Sep 2019 14:06:03 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 6CF181A05A; Tue, 3 Sep 2019 14:05:56 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 74A171A85B; Tue, 2 Apr 2019 03:29:50 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 32C946FB69; Tue, 2 Apr 2019 03:29:50 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 1DB731A859; Tue, 2 Apr 2019 03:29:50 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id DC9491A854 for ; Tue, 2 Apr 2019 03:29:47 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 89D966FB62 for ; Tue, 2 Apr 2019 03:29:47 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x833.google.com with SMTP id t28so13612197qte.6 for ; Mon, 01 Apr 2019 20:29:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9tnOYyTYIztI8J0yW9KG57YF0HOobbAIUtfqOaB3Gd8=; b=fblvU5fdjOZyuMvDVqMra3CXWdUbJ36BTFefoQseu3c8DG+S+u3KUZavtwQUrBocHm LX23lJGLCQfzlH0ZAe2tHo1qCGB6yhzUJXzpxEbwwrIk8xYXDMZ/y/NDezv+Kz5bEVaC ayIc+8j2Ju8zNwj97kMCrfTPk5DxNGpBhF8tWUfQoLbA+NOYraUApVxWL8UNP8NXSE9J 3blHl2CiFPPA2vqweuuqBfTRnw4LSbaGtBtKuKHWW35Y8Jf0Lnku4u03YsQFVv9O1aso cl6rYJmpUnwB2Pz4Cds8B/FHR/dsRtIOyGh9R+s9fz60aLVo4cfpUtQTqAzn3vB7bILh qBvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9tnOYyTYIztI8J0yW9KG57YF0HOobbAIUtfqOaB3Gd8=; b=NuXxVuHWlS4vH7f3qzaEQ6+F/NV5Hj7fULnvSxtk/LhwgVVqjJtlxYPon1jzAlTpqS RRTdMkL9RCNrP7sjz0pAy36BSKCppMbOhI3uE9unhriJ/AOV5QJbATC4RYn2td2WExNQ P+fyhdGOCuFHrbHNtm4eaZdsTnmxjstapjHXYSRhfu5vpa3oQs46fQHZBmnSJI3ejzs9 +aj1F0Kp07PzBCenSHqEg8bYw8zmfXKaE+FCZWbc1gBkQXY5zXMuTbyzRyJXx8ZfrYJE uE0yhei61+WQW7Dg8y0T0b2LifKovF9bAI4jkxU69014d/w4dxibB2SjODWDg+JDpE/r tlfg== X-Gm-Message-State: APjAAAXdYHg2+wmNrthgFCQaTs0TjGWIEnzgAvVIzJqIAftKLtJ+qSym NJg0bRqlUK2iAw44r2dl1DWtWQKTtqmcyQ+20r5sBw== X-Google-Smtp-Source: APXvYqzZhh2j+MKCGm2z+Y98HdwSP3xXA2XUv6tGscZuao0cPZtqIW0i/4b+6f9J8QXt/L99s0iP1ZpzmoFTFRwswB4= X-Received: by 2002:a0c:d4a2:: with SMTP id u31mr43743715qvh.139.1554175786840; Mon, 01 Apr 2019 20:29:46 -0700 (PDT) MIME-Version: 1.0 References: <86ef6l40q6.fsf@phe.ftfl.ca> <201904020226.x322QETb018513@gndrsh.dnsmgr.net> In-Reply-To: <201904020226.x322QETb018513@gndrsh.dnsmgr.net> From: Warner Losh Message-ID: Subject: Re: svn commit: r345786 - svnadmin/conf To: "Rodney W. Grimes" Cc: Joseph Mingrone , src-committers , svn-src-all , svn-src-svnadmin@freebsd.org Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 32C946FB69 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.975,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:06:23 -0000 X-Original-Date: Mon, 1 Apr 2019 21:29:34 -0600 X-List-Received-Date: Tue, 03 Sep 2019 14:06:23 -0000 On Mon, Apr 1, 2019, 8:26 PM Rodney W. Grimes wrote: > > Warner Losh writes: > > > > > On Mon, Apr 1, 2019 at 7:15 PM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > > wrote: > > > > >> > Author: jrm (ports committer) > > >> > Date: Mon Apr 1 21:34:58 2019 > > >> > New Revision: 345786 > > >> > URL: https://svnweb.freebsd.org/changeset/base/345786 > > > > >> > Log: > > >> > Set jhb@ as new mentor to anish@ > > > > >> > Approved by: core (brooks, seanc) > > >> > Differential Revision: https://reviews.freebsd.org/D19782 > > > > >> Can we please have a check list that when someones > > >> commit bit is reaped, or steps away from the project > > >> for more than N days, N being something rather small > > >> given the context here, that includes the item: > > > > >> x) Is this person a mentor of anyone? > > > > > > > Great idea... Joseph will put one together based on this round of > > > retirement... > > > > > > > > This is the current checklist: > > Should this be a publically visible check list? If I had know of it > I would not of even raised an issue. > That's the idea. This only handles the reap situation, which takes too long to leave > a menteee hanging, they are gone long before you get to this point. > > Perhaps adding an item to the new committers guide: > If a mentor should go unresponsive or seem to be inactive > in the project you should contact core@ asking for remediation or > reassignment of that mentor. > We've talked about a 6 month timeout for new committees. Nothing definite. > - Check for idle developers using: idle-commit-bits.pl base 18 > > > > - Source bits are taken in for safekeeping after three consecutive > emails about > > reaping go unanswered, or if the developer in question confirms that > the bit > > can be taken in. The email-to-idlers.pl script can be used to send > warning > > emails, but Ren? is currently taking care of this job. > > > > - Once it has been established that a bit is to be taken in, first check > the > > mentors file to see if this developer is a mentor. If so, a new > mentor must > > be found before the bit is taken in. > > I see no reason for delaying the reap action, that just further leaves > the mentee in limbo. Perhaps: > Once it has been established that a bit is to be take in, first check the > mentors file to see if this developer is a mentor. If so, create a core@ > action item to find them a replacement, inform the mentee that this action > item has been created, asking them if they have any input as to who might > be a good canidate. Reassign them to core@ in the mentors file. > We were able to find someone in 10ish minutes... there was no delay... it was one of the pre-commit activities. There was one more: is this person a vendor committer? Is so, we do need to do additional checks to help vendor relationships. Normally, these are managed well, but if we get to time out for a vendor committer, that suggests something may have broken down. At one point the vendor wanted a fast path into the project. We also need to check to see if the volunteer is in any groups as well. Warner > - If the developer whose bit to be removed is a mentee, remove the > developer > > from the mentors file. > > > > - Remove the developer from the access file. > > > > -- > > Joseph > -- > Rod Grimes > rgrimes@freebsd.org >