From owner-svn-src-head@freebsd.org Mon Sep 26 21:25:47 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 856E6BEBB01 for ; Mon, 26 Sep 2016 21:25:47 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 57F78ED2 for ; Mon, 26 Sep 2016 21:25:47 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22a.google.com with SMTP id r192so87192347ita.0 for ; Mon, 26 Sep 2016 14:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=g7qlcZIsvJcSWGm4eHOnkQm2DiWGwnkXDSyBqrFIX8k=; b=zvZqZeFdoCasrwHLotqYuATJPg1vNe/KMMBa8vjzIXTJazDbPXAsMv4qjAkHYoCOFU b3or56X6r5kd8DHp4kjtcjQM5AV833xYtVhikHL+xSZKrp35RTRenhaD3/m/zVGhilA/ RE41Rw+jh9IXwaEVph5YHyYxB/aStPeWXsK2rzU/ztOTGoebR+cAuqg1bnJv7C8gyrYx XCjaW7+DgfFgifcyAtYaTBJ5Y/IBft6/sxqeloB1ZDWMJg75NC6I0aEh82L/grPiFieE SQfqbVt5Pu5nps+TZ8hAN6Z1BGQ90xLcrtNESJig7zIs/xPJrL09ZAL2kiPz4+6BMK6y enPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=g7qlcZIsvJcSWGm4eHOnkQm2DiWGwnkXDSyBqrFIX8k=; b=MVqMzrpaN9kYbMmjc+tvlVCRiyQ7bVvq3xre2N7V2Xc/7njk+cTmtSQ+J4PgG3/soo /YoWr0G0r/YgcKxcItF2gaZ6LfxUID3RwRQQIqZF/4wk/xfDf5gRWlBlD1bRPAE33efq B5xiSuZXZUfKGSlKOX0C4IAFdqnx7zb+H8XlEPO4SDtKJC+MiKTvPm/mf9P21DDU38oj mG36u3GGuPbPhlhov8SqpF8jHBSkBLmxpbwfkikWV1DoqyGXI1liidbynMYHaCkIIbMs Yzmed/AFyyEkPz3zupMpDsP5o1OVsG+W0T0VCYoXacQ4SItyfwEXT+vcMiAB9rjJcjHt 7/0g== X-Gm-Message-State: AA6/9RlDqZOK0ElHn5h2YXW5fQxK1Hqm5OL6vL8sbLbAzRBNiyUyufz/eHgqrqO08tvBNAYjdFS81xgeJi8JLA== X-Received: by 10.36.152.5 with SMTP id n5mr86311itd.79.1474925146465; Mon, 26 Sep 2016 14:25:46 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.36.65.7 with HTTP; Mon, 26 Sep 2016 14:25:46 -0700 (PDT) X-Originating-IP: [69.53.245.200] In-Reply-To: <201609261538.u8QFc2Av023865@repo.freebsd.org> References: <201609261538.u8QFc2Av023865@repo.freebsd.org> From: Warner Losh Date: Mon, 26 Sep 2016 15:25:46 -0600 X-Google-Sender-Auth: rGzWGtGQpxHknTauzkZDBzQmG_U Message-ID: Subject: Re: svn commit: r306347 - head/lib/libc/tests To: Ruslan Bukin Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2016 21:25:47 -0000 Shouldn't we have MK_SSP == no on mips instead? That's how it's supposed to work. If it isn't, perhaps we should set it like that. Warner On Mon, Sep 26, 2016 at 9:38 AM, Ruslan Bukin wrote: > Author: br > Date: Mon Sep 26 15:38:02 2016 > New Revision: 306347 > URL: https://svnweb.freebsd.org/changeset/base/306347 > > Log: > Don't build SSP tests on MIPS as we dont have stack-protector > supported on this platform. > > Discussed with: brooks > Sponsored by: DARPA, AFRL > Sponsored by: HEIF5 > > Modified: > head/lib/libc/tests/Makefile > > Modified: head/lib/libc/tests/Makefile > ============================================================================== > --- head/lib/libc/tests/Makefile Mon Sep 26 15:30:30 2016 (r306346) > +++ head/lib/libc/tests/Makefile Mon Sep 26 15:38:02 2016 (r306347) > @@ -30,7 +30,8 @@ SUBDIR_DEPEND_tls= tls_dso > TESTS_SUBDIRS+= locale > .endif > > -.if ${MK_SSP} != "no" > +.if ${MK_SSP} != "no" && \ > + ${MACHINE_CPUARCH} != "mips" > TESTS_SUBDIRS+= ssp > .endif > >