From owner-svn-ports-head@freebsd.org Wed May 6 14:41:00 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 248B52C695B; Wed, 6 May 2020 14:41:00 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49HK5m0BHrz3Dr0; Wed, 6 May 2020 14:41:00 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id DF67928A72; Wed, 6 May 2020 14:40:59 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (aching.in.mat.cc [IPv6:2a01:678:42:0:5e80:b6ff:fe2c:99e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 97E68942D81; Wed, 6 May 2020 14:40:57 +0000 (UTC) Date: Wed, 6 May 2020 16:40:56 +0200 From: Mathieu Arnold To: Bryan Drewery Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, "Conrad E. Meyer" Subject: Re: svn commit: r533459 - head/Mk/Scripts Message-ID: <20200506144056.rtx2oygw73qq7rsw@aching.in.mat.cc> References: <202004301448.03UEmMwc053196@repo.freebsd.org> <276aef88-4619-b4b7-ee92-44999b5c787d@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="i6qhj2h5tqsdcwds" Content-Disposition: inline In-Reply-To: <276aef88-4619-b4b7-ee92-44999b5c787d@FreeBSD.org> X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 May 2020 14:41:00 -0000 --i6qhj2h5tqsdcwds Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 04, 2020 at 10:49:34AM -0700, Bryan Drewery wrote: > On 4/30/2020 7:48 AM, Mathieu Arnold wrote: > > Author: mat > > Date: Thu Apr 30 14:48:22 2020 > > New Revision: 533459 > > URL: https://svnweb.freebsd.org/changeset/ports/533459 > >=20 > > Log: > > When one patch fails, continue with appling patches. > > =20 > > This makes the process of make patch, fix fallout, make makepatch much > > easier as only one iteration is required. > > =20 > > While there, refactor things around, and streamline messages passed > > between functions. > > =20 > > PR: 244626 > > Reported by: cem > >=20 >=20 > Will this fail between stages? If a files/patch-* patch fails it should > not move on to extra patches as then makepatch / diffing will be wrong. > Even patch-* can lead to being wrong when considering local (not in > ports tree) patches. >=20 > I don't think this is good default behavior. No, it will try to apply all patches, and report all the failures. I am not sure where you are getting at. If you run `make patch; make makepatch` the usage would have been broken before and still is. If you run `make patch makepatch`, the usage does not change, if patching fails, it does not go into makepatch target, and if patching is ok, then makepatch runs and updates your patches. --=20 Mathieu Arnold --i6qhj2h5tqsdcwds Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl6yzHNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgLDJxAAifPWYJyQu9UOnAsa6S5E+KDCYIuUUf/b3m+q5Ez3OJ1GKWDM7N0Bwt4W Cat5OpLe8S/IaC7h7cgcFLRKhrTyuQw9KpUE6edfdw6ulBRAqcEzfEmEZgvwXN20 9ZG03IHebkwdcam/sPyQTxAXL/L4h+EfaWfMQVuPlvYz8Em7SRu1d0uCoRWC07jt abbf4I4Us2N8YHm4YcObBY48XrPXzvEx0TIVnP3ySamm2PcUgyPHID/GPL4EYlXK kHCKisnAsV9u8zcs87QxZCN1DnvHhSHgdCpLC2Tj1m+quV2osKXrFmvRXcvqMfe1 cm35bXz1rcFTjrjc0mEp6kMr09XZkMWuL8R7YA1piTOvoDroHwAOmrGltlSuydkm 8WdoIOHVoRkQV1TjMTFMrjLFW1Aj9et1F9wJOJEyVA4VJgHV02pWdh54KAG5dOik EjRYgvq+mW/dWHRh/P1cF1CoWBLvY+WiaP/iz3FTB2djDAVsHFlvPd1zeHyub2gY W3YJJr90xMR3NuKlh8NcudK9Yd+KH3vSU7lgtZCMGAvkPL6htz0v6FlOBUBbxV4N sp1EzbaMGwh0/Wv7M461vJt7/Zi8dO0ACLDpsG9KqBX9mlD1XSsibeefkoPO+D6U nu8NkzYPo9dqR/nmMJkHr5FgDB7Z3Pte7wEpFXNYSSNu3IXColM= =ash1 -----END PGP SIGNATURE----- --i6qhj2h5tqsdcwds--