From owner-freebsd-gnome@FreeBSD.ORG Sun May 13 16:08:16 2012 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D7A34106566C for ; Sun, 13 May 2012 16:08:16 +0000 (UTC) (envelope-from bsam@passap.ru) Received: from forward14.mail.yandex.net (forward14.mail.yandex.net [IPv6:2a02:6b8:0:801::4]) by mx1.freebsd.org (Postfix) with ESMTP id 57D0E8FC18 for ; Sun, 13 May 2012 16:08:16 +0000 (UTC) Received: from smtp11.mail.yandex.net (smtp11.mail.yandex.net [95.108.130.67]) by forward14.mail.yandex.net (Yandex) with ESMTP id E1D5419817D8 for ; Sun, 13 May 2012 20:08:14 +0400 (MSK) Received: from smtp11.mail.yandex.net (localhost [127.0.0.1]) by smtp11.mail.yandex.net (Yandex) with ESMTP id CF2EB7E04C0 for ; Sun, 13 May 2012 20:08:14 +0400 (MSK) Received: from 87.249.28.58.tel.ru (87.249.28.58.tel.ru [87.249.28.58]) by smtp11.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 8EBOtTJM-8EB0WIUI; Sun, 13 May 2012 20:08:14 +0400 Message-ID: <4FAFDC6E.80409@passap.ru> Date: Sun, 13 May 2012 20:08:14 +0400 From: Boris Samorodov User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:12.0) Gecko/20120428 Thunderbird/12.0 MIME-Version: 1.0 To: gnome@freebsd.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: Subject: [patch] [CLANG] devel/gamin: does not compile with clang X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 May 2012 16:08:16 -0000 Hi! The port devel/gamin does not compile with clang: ----- clang -DHAVE_CONFIG_H -I. -I.. -I.. -I../libgamin -I../protocol -I../lib -I../libgamin -I/usr/local/include/glib-2.0 -DBINDIR=\""/usr/local/libexec"\" -DG_DISABLE_DEPRECATED -DGAM_DEBUG_ENABLED -DHAVE_LINUX -I/usr/local/include -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wsign-compare -Wno-sign-compare -g -O2 -pipe -fno-strict-aliasing -MT gam_eq.o -MD -MP -MF .deps/gam_eq.Tpo -c -o gam_eq.o gam_eq.c gam_eq.c:127:3: error: non-void function 'gam_eq_flush' should return a value [-Wreturn-type] return; ^ 1 error generated. gmake[3]: *** [gam_eq.o] Ошибка 1 ----- I'm not sure if it is TRTD but since the return value is not checked, I propose the following patch (compiles and seems to work): ----- % cat /usr/ports/devel/gamin/files/patch-server_gam_eq.c --- server/gam_eq.c.orig 2012-05-13 19:42:20.257794534 +0400 +++ server/gam_eq.c 2012-05-13 19:44:41.228799909 +0400 @@ -124,7 +124,7 @@ gam_eq_flush (gam_eq_t *eq, GamConnDataP { gboolean done_work = FALSE; if (!eq) - return; + return FALSE; #ifdef GAM_EQ_VERBOSE GAM_DEBUG(DEBUG_INFO, "gam_eq: Flushing event queue for %s\n", gam_connection_get_pidname (conn)); ----- -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve