From owner-freebsd-current@FreeBSD.ORG Thu Sep 6 01:34:38 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E5F816A46E for ; Thu, 6 Sep 2007 01:34:38 +0000 (UTC) (envelope-from weongyo.jeong@gmail.com) Received: from rv-out-0910.google.com (rv-out-0910.google.com [209.85.198.187]) by mx1.freebsd.org (Postfix) with ESMTP id 3BBF613C45E for ; Thu, 6 Sep 2007 01:34:37 +0000 (UTC) (envelope-from weongyo.jeong@gmail.com) Received: by rv-out-0910.google.com with SMTP id l15so4687rvb for ; Wed, 05 Sep 2007 18:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:date:to:cc:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:organization:x-operation-sytem:from; bh=03iQtWv4MTtighqPzi2qTDJJgnTu8z76zlhWTM1jgrQ=; b=ssrGRHA2KqnzmUIhC+3wGq8pTZ2mnCT951ezISSSbFUv3bBHPO/SWyRIBrjZttJoYFgdJul3JQ0LGzUi82e4gR9PJEhwr5l8VO6NkBMevHTmmJ66IZ1UwUhEYb2A4idLz6p1RM6KVhZHMkN8idSj0SRegojZWOG+RbWbLxzP82Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:to:cc:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:organization:x-operation-sytem:from; b=OX2jHbtbOm8wBBxFaGSukxTtmEDt3gfG3+xaLdzdXBZQ6T/VyJdOUiGusEVhSa5zz0Ki8xE5H8pADqphMJ48t2U2nphaUXrmzsxHJxDCBhOGzkr5Wt3LaaIAT20DcblTVIwSrulp/Ng9RnwsK3RUE8litB4g6X5hQwqDWiAVoVo= Received: by 10.114.73.1 with SMTP id v1mr23457waa.1189042473529; Wed, 05 Sep 2007 18:34:33 -0700 (PDT) Received: from freebsd.weongyo.org ( [211.53.35.67]) by mx.google.com with ESMTPS id k23sm8439214waf.2007.09.05.18.34.29 (version=SSLv3 cipher=OTHER); Wed, 05 Sep 2007 18:34:31 -0700 (PDT) Received: by freebsd.weongyo.org (sSMTP sendmail emulation); Thu, 6 Sep 2007 10:34:21 +0900 Date: Thu, 6 Sep 2007 10:34:21 +0900 To: Ted Lindgreen Message-ID: <20070906013421.GC2809@freebsd.weongyo.org> Mail-Followup-To: Ted Lindgreen , freebsd-current@freebsd.org References: <200708301414.l7UEEMSi004166@omval.tednet.nl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="cvVnyQ+4j833TQvp" Content-Disposition: inline In-Reply-To: <200708301414.l7UEEMSi004166@omval.tednet.nl> User-Agent: Mutt/1.4.2.3i Organization: CDNetworks. X-Operation-Sytem: FreeBSD From: Weongyo Jeong Cc: freebsd-current@freebsd.org Subject: Re: New if_zyd driver X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2007 01:34:38 -0000 --cvVnyQ+4j833TQvp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 30, 2007 at 04:14:22PM +0200, Ted Lindgreen wrote: > Hi, > > I'd like to report success with new zyd driver, and to thank the > author for his work. > > I had tried the diff that was published previously. With ifconfig, > the device associated with the access-point, but no traffic was > possible. With the files now included in CVS, the device works! > > However, the stick needs to be inserted after booting up. Then I can > also remove the stick without ill effects (for logmessages see below). > > When the stick is present during boot, the log shows: > Aug 30 15:25:17 lapje kernel: zyd0: on uhub4 > Aug 30 15:25:17 lapje kernel: zyd0: setting config no failed > and there are 2 problems: > 1. "ifconfig -a" shows no zyd0 device. > 2. when the stick is removed, the laptop panics (page fault) This panic is caused by a zyd driver bug and would be fixed by a patch that just prevents a panic. The patch is attached with this email. After testing why the stick can't be initialized during booting up, I can see that this condition only appears when I reboot my FreeBSD, not power on. It was loaded successfully whenever I power on. I think this problem is caused by the problem of the usb stick hardware reset and take some time to fix though I am looking at the code. Thank you for your feedback! Best Regards, Weongyo Jeong --cvVnyQ+4j833TQvp Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="zyd_patch_2ted_20070905.diff" Index: if_zyd.c =================================================================== RCS file: /data/zyd/zyd/if_zyd.c,v retrieving revision 1.24 diff -u -r1.24 if_zyd.c --- if_zyd.c 5 Sep 2007 02:20:11 -0000 1.24 +++ if_zyd.c 5 Sep 2007 02:21:37 -0000 @@ -307,7 +307,10 @@ STAILQ_INIT(&sc->sc_rqh); - zyd_attachhook(sc); + if (zyd_attachhook(sc) != 0) { + if_free(ifp); + return ENXIO; + } return 0; } --cvVnyQ+4j833TQvp--