From owner-svn-src-all@freebsd.org  Fri May 25 06:52:05 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 75C27F74466;
 Fri, 25 May 2018 06:52:05 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2F78975257;
 Fri, 25 May 2018 06:52:05 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 288081A268; Fri, 25 May 2018 06:52:05 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Fabien Thomas <fabient@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r334054 - in head: sys/kern sys/netipsec
 tools/tools/crypto usr.bin/netstat
References: <201805221554.w4MFsPQA083334@repo.freebsd.org>
Date: Fri, 25 May 2018 08:52:01 +0200
In-Reply-To: <201805221554.w4MFsPQA083334@repo.freebsd.org> (Fabien Thomas's
 message of "Tue, 22 May 2018 15:54:25 +0000 (UTC)")
Message-ID: <efi0-448e-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 May 2018 06:52:05 -0000

Fabien Thomas <fabient@FreeBSD.org> writes:

> +		IPSECSTAT_INC(ips_spdcache_hits);
> +
> +		SPDCACHE_UNLOCK(hashv);
> +		goto out;
> +	}
> +
> +	IPSECSTAT_INC(ips_spdcache_misses);

Breaks kernel build with "nooption IPSEC":

ld: error: undefined symbol: vnet_entry_ipsec4stat
>>> referenced by key.c:933 (/usr/src/sys/netipsec/key.c:933)
>>>               key.o:(key_allocsp)

ld: error: undefined symbol: vnet_entry_ipsec4stat
>>> referenced by key.c:939 (/usr/src/sys/netipsec/key.c:939)
>>>               key.o:(key_allocsp)