From owner-freebsd-net@FreeBSD.ORG Mon Dec 31 22:13:02 2007 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86CA916A421 for ; Mon, 31 Dec 2007 22:13:02 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outS.internet-mail-service.net (outS.internet-mail-service.net [216.240.47.242]) by mx1.freebsd.org (Postfix) with ESMTP id 725DC13C4E7 for ; Mon, 31 Dec 2007 22:13:02 +0000 (UTC) (envelope-from julian@elischer.org) Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160) by out.internet-mail-service.net (qpsmtpd/0.40) with ESMTP; Mon, 31 Dec 2007 14:13:01 -0800 Received: from julian-mac.elischer.org (localhost [127.0.0.1]) by idiom.com (Postfix) with ESMTP id 2147D126DD5 for ; Mon, 31 Dec 2007 14:13:01 -0800 (PST) Message-ID: <4779697A.4050806@elischer.org> Date: Mon, 31 Dec 2007 14:13:14 -0800 From: Julian Elischer User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: FreeBSD Net Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: m_freem() X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2007 22:13:02 -0000 m_freem() would be a perfect candidate for an inline function. (or even macro). in the case where m is null, no function call would even be made... The whole function is only 2 lines, and it gets called once for every packet :-) BUT it's a part of the ABI to have it as a function for RELENG_7 and earlier... 1/ can we change it in -current/RELENG_8 2/ if not is there such a thing as an inline that has a function version too? (I have vague memories of that being possible...)