From owner-freebsd-bugs  Mon Dec 24 17:20: 7 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 72FE437B41A
	for <freebsd-bugs@hub.freebsd.org>; Mon, 24 Dec 2001 17:20:01 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id fBP1K1l65288;
	Mon, 24 Dec 2001 17:20:01 -0800 (PST)
	(envelope-from gnats)
Received: from mail.ubergeeks.com (lorax.ubergeeks.com [209.145.65.55])
	by hub.freebsd.org (Postfix) with ESMTP id 67FBB37B41B
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Dec 2001 17:11:15 -0800 (PST)
Received: (from adrian@localhost)
	by mail.ubergeeks.com (8.11.6/8.11.6) id fBP1BDo70474;
	Mon, 24 Dec 2001 20:11:13 -0500 (EST)
	(envelope-from adrian)
Message-Id: <200112250111.fBP1BDo70474@mail.ubergeeks.com>
Date: Mon, 24 Dec 2001 20:11:13 -0500 (EST)
From: Adrian Filipi-Martin <adrian@ubergeeks.com>
Reply-To: Adrian Filipi-Martin <adrian@ubergeeks.com>
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.113
Subject: bin/33158: sh expr cleanup in MAKEDEV
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         33158
>Category:       bin
>Synopsis:       sh expr cleanup in MAKEDEV
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 24 17:20:01 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Adrian Filipi-Martin
>Release:        FreeBSD 4.5-PRERELEASE i386
>Organization:
Ubergeeks Consulting
>Environment:
System: FreeBSD lorax.ubergeeks.com 4.5-PRERELEASE FreeBSD 4.5-PRERELEASE #16: Sat Dec 22 13:54:55 EST 2001 root@lorax.ubergeeks.com:/usr/obj/usr/src/sys/LORAX i386

>Description:
	When the MAKEDEV script was converted from extensive use
	of the expr(1) command to using sh builtin $((expr))
	arithmatic, a couple of no longer needed escapes of some
	operator characters were missed.

>How-To-Repeat:
	Look at the code.
>Fix:
	Apply this patch.


--- MAKEDEV.orig	Mon Dec 24 20:03:43 2001
+++ MAKEDEV	Mon Dec 24 20:04:23 2001
@@ -1599,8 +1599,8 @@
 	*c) unit=12;;	*d) unit=13;;	*e) unit=14;;	*f) unit=15;;
 	esac
 	case $i in
-	ttyy?)  unit=$(($unit \+ 16));;
-	ttyz?)  unit=$(($unit \+ 32));;
+	ttyy?)  unit=$(($unit + 16));;
+	ttyz?)  unit=$(($unit + 32));;
 	esac
 	mknod $i c 42 $unit
 	;;
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message