From owner-svn-src-all@FreeBSD.ORG Sat Mar 28 19:34:01 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 953B04BF; Sat, 28 Mar 2015 19:34:01 +0000 (UTC) Received: from relay.mailchannels.net (aso-006-i440.relay.mailchannels.net [23.91.64.121]) by mx1.freebsd.org (Postfix) with ESMTP id 61CE4D4C; Sat, 28 Mar 2015 19:33:59 +0000 (UTC) X-Sender-Id: duocircle|x-authuser|hippie Received: from smtp4.ore.mailhop.org (ip-10-33-12-218.us-west-2.compute.internal [10.33.12.218]) by relay.mailchannels.net (Postfix) with ESMTPA id 9F2F01205A7; Sat, 28 Mar 2015 19:33:52 +0000 (UTC) X-Sender-Id: duocircle|x-authuser|hippie Received: from smtp4.ore.mailhop.org (smtp4.ore.mailhop.org [10.45.8.167]) (using TLSv1 with cipher DHE-RSA-AES256-SHA) by 0.0.0.0:2500 (trex/5.4.8); Sat, 28 Mar 2015 19:33:52 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: duocircle|x-authuser|hippie X-MailChannels-Auth-Id: duocircle X-MC-Loop-Signature: 1427571232747:1848504596 X-MC-Ingress-Time: 1427571232747 Received: from c-73-34-117-227.hsd1.co.comcast.net ([73.34.117.227] helo=ilsoft.org) by smtp4.ore.mailhop.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82) (envelope-from ) id 1YbwUQ-0005Re-GI; Sat, 28 Mar 2015 19:33:50 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t2SJXnTk052752; Sat, 28 Mar 2015 13:33:49 -0600 (MDT) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX18b7Pz4VYq2PSkNzUaGWksy Message-ID: <1427571229.20823.1.camel@freebsd.org> Subject: Re: svn commit: r280790 - in head/sys: conf dev/hwpmc From: Ian Lepore To: "Bjoern A. Zeeb" Date: Sat, 28 Mar 2015 13:33:49 -0600 In-Reply-To: References: <201503281857.t2SIvErQ096549@svn.freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-AuthUser: hippie Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2015 19:34:01 -0000 On Sat, 2015-03-28 at 19:01 +0000, Bjoern A. Zeeb wrote: > > On 28 Mar 2015, at 18:57 , Bjoern A. Zeeb wrote: > > > > Author: bz > > Date: Sat Mar 28 18:57:13 2015 > > New Revision: 280790 > > URL: https://svnweb.freebsd.org/changeset/base/280790 > > > > Log: > > Remove all the handcrafted assembly in hwpmc_armv7.c and use the > > common (autogenerated) versions. Removes extra vertical space, > > and makes it easier to grep for usage throughout the tree. > > Conditionally compile only for arm6 [1] (yes sounds odd but is right). > > > > Submitted by: andrew [1] > > Reviewed by: gnn, andrew (ian earlier version I think) > > and ian (I missed the official review for the latest version; sorry) > No problem. IMO, if a commit references a phab revision, there's no need to list individual reviewers as well, since the phab info already contains all that. -- Ian