From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat May 20 16:41:36 2006
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@FreeBSD.org
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D9BA916A421;
	Sat, 20 May 2006 16:41:36 +0000 (UTC)
	(envelope-from jarrod@netleader.com.au)
Received: from smtp1.adl2.internode.on.net (smtp1.adl2.internode.on.net
	[203.16.214.181])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 46D9643D45;
	Sat, 20 May 2006 16:41:35 +0000 (GMT)
	(envelope-from jarrod@netleader.com.au)
Received: from [192.168.0.8] (wallace.netleader.com.au [203.122.246.247])
	by smtp1.adl2.internode.on.net (8.13.6/8.13.5) with ESMTP id
	k4KGfXNk087356; Sun, 21 May 2006 02:11:33 +0930 (CST)
	(envelope-from jarrod@netleader.com.au)
Mime-Version: 1.0 (Apple Message framework v750)
In-Reply-To: <200605180816.k4I8GK0p064399@freefall.freebsd.org>
References: <200605180816.k4I8GK0p064399@freefall.freebsd.org>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <90AD2202-B3C9-47EE-AEC7-3BD04B258F71@netleader.com.au>
Content-Transfer-Encoding: 7bit
From: Jarrod Sayers <jarrod@netleader.com.au>
Date: Sun, 21 May 2006 02:11:31 +0930
To: Sam Lawrance <lawrance@FreeBSD.org>, freebsd-ports-bugs@FreeBSD.org
X-Mailer: Apple Mail (2.750)
Cc: 
Subject: Re: ports/97328: [maintainer-update] net-mgmt/nagios: Update to
	Nagios 2.3.1
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 20 May 2006 16:41:36 -0000

Sam,

I believe I have located the problem.  The declaration of INT_MAX  
appears in limits.h which is not directly included anywhere in the  
distribution, though is tested by the configure script.  From what I  
can see, limits.h has worked its way in from the inclusion of  
pthread.h inside ${WRKSRC}/include/config.h.in on earlier FreeBSD  
releases (this build of Nagios is the first to use INT_MAX).

The pthread.h found on -CURRENT installations does not include this,  
but includes machine/_limits.h instead which, following those  
#includes, doesn't end up with a declaration for INT_MAX.

I have updated the diff (use URL below) to include a patch to add a  
manual (and hopefully temporary) #include <limits.h> where needed to  
replicate previous behavior:
http://www.netleader.com.au/~jarrod/FreeBSD/net-mgmt-nagios-2.3.1- 
pthread.diff

Files Modified:
- ports/net-mgmt/nagios/Makefile
- ports/net-mgmt/nagios/distinfo

Files Added:
- ports/net-mgmt/nagios/files/patch-cgi__getcgi.c

Thanks for spotting that, I have since added a -CURRENT machine into  
our build pool.

Jarrod.