From owner-svn-ports-all@freebsd.org Sat Jun 11 20:39:40 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4FBB9AF089B; Sat, 11 Jun 2016 20:39:40 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EC8932A80; Sat, 11 Jun 2016 20:39:39 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u5BKddZW010056; Sat, 11 Jun 2016 20:39:39 GMT (envelope-from garga@FreeBSD.org) Received: (from garga@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u5BKddN9010054; Sat, 11 Jun 2016 20:39:39 GMT (envelope-from garga@FreeBSD.org) Message-Id: <201606112039.u5BKddN9010054@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: garga set sender to garga@FreeBSD.org using -f From: Renato Botelho Date: Sat, 11 Jun 2016 20:39:39 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r416751 - in head/security/sudo: . files X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jun 2016 20:39:40 -0000 Author: garga Date: Sat Jun 11 20:39:38 2016 New Revision: 416751 URL: https://svnweb.freebsd.org/changeset/ports/416751 Log: Add a patch to fix sudo bug #743 that causes a bug where it dereference a NULL pointer when it looks up a negative cached entry which is stored as a NULL passwd or group struct pointer PR: 208198 Submitted by: Fredrik Eriksson Obtained from: https://www.sudo.ws/repos/sudo/rev/1d13341d53ec Sponsored by: Rubicon Communications (Netgate) Added: head/security/sudo/files/patch-fix_bz208198 (contents, props changed) Modified: head/security/sudo/Makefile Modified: head/security/sudo/Makefile ============================================================================== --- head/security/sudo/Makefile Sat Jun 11 20:22:00 2016 (r416750) +++ head/security/sudo/Makefile Sat Jun 11 20:39:38 2016 (r416751) @@ -3,7 +3,7 @@ PORTNAME= sudo PORTVERSION= 1.8.16 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= security MASTER_SITES= SUDO Added: head/security/sudo/files/patch-fix_bz208198 ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/security/sudo/files/patch-fix_bz208198 Sat Jun 11 20:39:38 2016 (r416751) @@ -0,0 +1,35 @@ +--- plugins/sudoers/pwutil.c Thu Apr 28 15:27:53 2016 -0600 ++++ plugins/sudoers/pwutil.c Wed May 04 08:55:21 2016 -0600 +@@ -139,8 +139,8 @@ + item = node->data; + sudo_debug_printf(SUDO_DEBUG_DEBUG, + "%s: uid %u [%s] -> user %s [%s] (cache hit)", __func__, +- (unsigned int)uid, key.registry, item->d.pw->pw_name, +- item->registry); ++ (unsigned int)uid, key.registry, ++ item->d.pw ? item->d.pw->pw_name : "unknown", item->registry); + goto done; + } + /* +@@ -202,8 +202,8 @@ + if ((node = rbfind(pwcache_byname, &key)) != NULL) { + item = node->data; + sudo_debug_printf(SUDO_DEBUG_DEBUG, +- "%s: user %s [%s] -> uid %u [%s] (cache hit)", __func__, name, +- key.registry, (unsigned int)item->d.pw->pw_uid, item->registry); ++ "%s: user %s [%s] -> uid %d [%s] (cache hit)", __func__, name, ++ key.registry, item->d.pw ? (int)item->d.pw->pw_uid : -1, item->registry); + goto done; + } + /* +@@ -461,8 +461,8 @@ + item = node->data; + sudo_debug_printf(SUDO_DEBUG_DEBUG, + "%s: gid %u [%s] -> group %s [%s] (cache hit)", __func__, +- (unsigned int)gid, key.registry, item->d.gr->gr_name, +- item->registry); ++ (unsigned int)gid, key.registry, ++ item->d.gr ? item->d.gr->gr_name : "unknown", item->registry); + goto done; + } + /*