Date: Sat, 11 Jun 2016 20:39:39 +0000 (UTC) From: Renato Botelho <garga@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r416751 - in head/security/sudo: . files Message-ID: <201606112039.u5BKddN9010054@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: garga Date: Sat Jun 11 20:39:38 2016 New Revision: 416751 URL: https://svnweb.freebsd.org/changeset/ports/416751 Log: Add a patch to fix sudo bug #743 that causes a bug where it dereference a NULL pointer when it looks up a negative cached entry which is stored as a NULL passwd or group struct pointer PR: 208198 Submitted by: Fredrik Eriksson <fredrik.eriksson@loopia.se> Obtained from: https://www.sudo.ws/repos/sudo/rev/1d13341d53ec Sponsored by: Rubicon Communications (Netgate) Added: head/security/sudo/files/patch-fix_bz208198 (contents, props changed) Modified: head/security/sudo/Makefile Modified: head/security/sudo/Makefile ============================================================================== --- head/security/sudo/Makefile Sat Jun 11 20:22:00 2016 (r416750) +++ head/security/sudo/Makefile Sat Jun 11 20:39:38 2016 (r416751) @@ -3,7 +3,7 @@ PORTNAME= sudo PORTVERSION= 1.8.16 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= security MASTER_SITES= SUDO Added: head/security/sudo/files/patch-fix_bz208198 ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/security/sudo/files/patch-fix_bz208198 Sat Jun 11 20:39:38 2016 (r416751) @@ -0,0 +1,35 @@ +--- plugins/sudoers/pwutil.c Thu Apr 28 15:27:53 2016 -0600 ++++ plugins/sudoers/pwutil.c Wed May 04 08:55:21 2016 -0600 +@@ -139,8 +139,8 @@ + item = node->data; + sudo_debug_printf(SUDO_DEBUG_DEBUG, + "%s: uid %u [%s] -> user %s [%s] (cache hit)", __func__, +- (unsigned int)uid, key.registry, item->d.pw->pw_name, +- item->registry); ++ (unsigned int)uid, key.registry, ++ item->d.pw ? item->d.pw->pw_name : "unknown", item->registry); + goto done; + } + /* +@@ -202,8 +202,8 @@ + if ((node = rbfind(pwcache_byname, &key)) != NULL) { + item = node->data; + sudo_debug_printf(SUDO_DEBUG_DEBUG, +- "%s: user %s [%s] -> uid %u [%s] (cache hit)", __func__, name, +- key.registry, (unsigned int)item->d.pw->pw_uid, item->registry); ++ "%s: user %s [%s] -> uid %d [%s] (cache hit)", __func__, name, ++ key.registry, item->d.pw ? (int)item->d.pw->pw_uid : -1, item->registry); + goto done; + } + /* +@@ -461,8 +461,8 @@ + item = node->data; + sudo_debug_printf(SUDO_DEBUG_DEBUG, + "%s: gid %u [%s] -> group %s [%s] (cache hit)", __func__, +- (unsigned int)gid, key.registry, item->d.gr->gr_name, +- item->registry); ++ (unsigned int)gid, key.registry, ++ item->d.gr ? item->d.gr->gr_name : "unknown", item->registry); + goto done; + } + /*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201606112039.u5BKddN9010054>