Date: Mon, 10 Aug 2009 11:55:19 -0700 From: Xin LI <delphij@delphij.net> To: Adrian Penisoara <ady@freebsd.ady.ro> Cc: freebsd-rc@freebsd.org, Doug Barton <dougb@freebsd.org>, d@delphij.net Subject: Re: [RFC] script for binding ARP <-> IP pairs Message-ID: <4A806D17.9020404@delphij.net> In-Reply-To: <78cb3d3f0908101113s412021adk8956dd083a8fed72@mail.gmail.com> References: <4A7B2792.4090803@delphij.net> <4A7B487B.8060303@FreeBSD.org> <4A7F948A.2040602@delphij.net> <4A7F9EC6.9090605@FreeBSD.org> <4A7FAA42.4030607@delphij.net> <alpine.BSF.2.00.0908092234390.50801@qbhto.arg> <78cb3d3f0908101113s412021adk8956dd083a8fed72@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------010607040803050109010607
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi, Adrian,
Adrian Penisoara wrote:
[...]
> Just a bit of QC/improvement:
>
> Index: etc/rc.d/static_arp
> ===================================================================
> - echo -n 'Binding static ARP pair:'
> + echo -n 'Binding static ARP pair(s):'
Thanks, I have changed both.
> - arp_args=`echo ${arp_args} | sed -e
> s,..:..:..:..:..:..,,g`
> + arp_args=`echo ${arp_args} | awk '{ print $1 }'`
After carefully reading the sh(1) manual, I find another way which does
not need to use any sed/awk at all:
arp -d ${arp_args%%[ ]*} > /dev/null 2>&1
> Index: share/man/man5/rc.conf.5
> ===================================================================
> -Set to the list of static ARP paris that are to be added at system
> +Set to the list of static ARP pairs that are to be added at system
Thanks, changed in the patch.
Here is the revised patch based on your comments.
Cheers,
- --
Xin LI <delphij@delphij.net> http://www.delphij.net/
FreeBSD - The Power to Serve!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (FreeBSD)
iEYEARECAAYFAkqAbRYACgkQi+vbBBjt66ADfwCgp79vVw0kMv1qYYc7Lmjkwn6s
FEAAnjjOxHVBifAKpbnnU01XOZynij6W
=P5jW
-----END PGP SIGNATURE-----
--------------010607040803050109010607
Content-Type: text/plain;
name="staticarp-20090810.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="staticarp-20090810.diff"
Index: etc/defaults/rc.conf
===================================================================
--- etc/defaults/rc.conf (revision 196086)
+++ etc/defaults/rc.conf (working copy)
@@ -357,6 +357,7 @@
### Network routing options: ###
defaultrouter="NO" # Set to default gateway (or NO).
+static_arp_pairs="" # Set to static ARP list (or leave empty).
static_routes="" # Set to static route list (or leave empty).
natm_static_routes="" # Set to static route list for NATM (or leave empty).
gateway_enable="NO" # Set to YES if this host will be a gateway.
Index: etc/rc.d/Makefile
===================================================================
--- etc/rc.d/Makefile (revision 196086)
+++ etc/rc.d/Makefile (working copy)
@@ -32,7 +32,7 @@
random rarpd resolv rfcomm_pppd_server root \
route6d routed routing rpcbind rtadvd rwho \
savecore sdpd securelevel sendmail \
- serial sppp statd swap1 \
+ serial static_arp sppp statd swap1 \
syscons sysctl syslogd \
timed tmp \
ugidfw \
Index: etc/rc.d/static_arp
===================================================================
--- etc/rc.d/static_arp (revision 0)
+++ etc/rc.d/static_arp (revision 0)
@@ -0,0 +1,69 @@
+#!/bin/sh
+#
+# Copyright (c) 2009 Xin LI <delphij@FreeBSD.org>
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+# OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+# HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+# LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+# SUCH DAMAGE.
+#
+# Configure static ARP table
+#
+# $FreeBSD$
+#
+
+# PROVIDE: static_arp
+# REQUIRE: netif
+# KEYWORD: nojail
+
+. /etc/rc.subr
+
+name="static_arp"
+start_cmd="static_arp_start"
+stop_cmd="static_arp_stop"
+
+static_arp_start()
+{
+ if [ -n "${static_arp_pairs}" ]; then
+ echo -n 'Binding static ARP pair(s):'
+ for e in ${static_arp_pairs}; do
+ echo -n " ${e}"
+ eval arp_args=\$arp_${e}
+ arp -S ${arp_args} >/dev/null 2>&1
+ done
+ echo '.'
+ fi
+}
+
+static_arp_stop()
+{
+ if [ -n "${static_arp_pairs}" ]; then
+ echo -n 'Unbinding static ARP pair(s):'
+ for e in ${static_arp_pairs}; do
+ echo -n " ${e}"
+ eval arp_args=\$arp_${e}
+ arp -d ${arp_args%%[ ]*} > /dev/null 2>&1
+ done
+ echo '.'
+ fi
+}
+
+load_rc_config $name
+run_rc_command "$1"
Index: share/man/man5/rc.conf.5
===================================================================
--- share/man/man5/rc.conf.5 (revision 196086)
+++ share/man/man5/rc.conf.5 (working copy)
@@ -24,7 +24,7 @@
.\"
.\" $FreeBSD$
.\"
-.Dd April 10, 2009
+.Dd August 10, 2009
.Dt RC.CONF 5
.Os
.Sh NAME
@@ -2227,6 +2227,23 @@
.Pq Vt str
The IPv6 equivalent of
.Va defaultrouter .
+.It Va static_arp_pairs
+.Pq Vt str
+Set to the list of static ARP pairs that are to be added at system
+boot time.
+For each whitespace separated
+.Ar element
+in the value, a
+.Va
+arp_ Ns Aq Ar element
+variable is assumed to exist whose contents will later be passed to a
+.Dq Nm arp Cm -S
+operation.
+For example
+.Bd -literal
+static_arp_pairs="gw"
+arp_gw="192.168.1.1 00:01:02:03:04:05"
+.Ed
.It Va static_routes
.Pq Vt str
Set to the list of static routes that are to be added at system
--------------010607040803050109010607--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A806D17.9020404>