From owner-freebsd-arch@FreeBSD.ORG Fri Mar 26 16:12:52 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4938F1065674; Fri, 26 Mar 2010 16:12:52 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id DEF5B8FC20; Fri, 26 Mar 2010 16:12:51 +0000 (UTC) Received: from outgoing.leidinger.net (pD9E2C1F3.dip.t-dialin.net [217.226.193.243]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id A2653844054; Fri, 26 Mar 2010 17:12:44 +0100 (CET) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id B1B9A5074; Fri, 26 Mar 2010 17:12:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1269619961; bh=uaAKnfa+49et7kUbwI2eCzqIPsJid1OFqjjcP1prMXg=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=kMEuM66nant8VV2UHeNs9Au1Ly1rLgVXtwPOr3d7pLE7kSSuk4vcm9Uum9a6FUXLi CxhjGGACh1SaRVt2rXUjxw7ajHVdKSXOlykvDVR2OMwQFxL5ZyPSCcePhvIWikOq2V K6oT4KvxpoEdpSRuwwTHm1WvYuVpU/ERmF8Z2U7I84zbJIM8wrnjTsK6BF+3mOrf2Q eqbDitisjuN+nXK7WZCuCvP89117Ux7I73AwoPVTVvXrYRl8ITItEFmUrWsIbbW/pb B0lG0a1nYPbkd9xw3lCTlJl1PV0fAnkrWBBGo8ah+Azd6zpCxNX/zLU00LTQwuwkqg GRlDU+WCXZA9A== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id o2QGCfHq068172; Fri, 26 Mar 2010 17:12:41 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Fri, 26 Mar 2010 17:12:41 +0100 Message-ID: <20100326171241.16524bklcroedou8@webmail.leidinger.net> Date: Fri, 26 Mar 2010 17:12:41 +0100 From: Alexander Leidinger To: "M. Warner Losh" References: <201003250749.57994.jhb@freebsd.org> <20100325.073736.635700942514937954.imp@bsdimp.com> <20100326101524.15695bisy2324t8g@webmail.leidinger.net> <20100326.093717.857133809997909007.imp@bsdimp.com> In-Reply-To: <20100326.093717.857133809997909007.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: A2653844054.1EACD X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.44, required 6, autolearn=disabled, ALL_TRUSTED -1.44, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1270224767.57603@9fr1sFGZ9x/Xo+56skf6oQ X-EBL-Spam-Status: No Cc: rwatson@freebsd.org, freebsd-arch@freebsd.org Subject: Re: CTF patch for testing/review X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2010 16:12:52 -0000 Quoting "M. Warner Losh" (from Fri, 26 Mar 2010 09:37:17 -0600 (MDT)): > In message: <20100326101524.15695bisy2324t8g@webmail.leidinger.net> > Alexander Leidinger writes: > : Quoting "M. Warner Losh" (from Thu, 25 Mar 2010 > : 07:37:36 -0600 (MDT)): > : > : > In general, I think this is OK. I'd like to see the revised patch > : > before it is committed. > : > : And here it is: > : http://www.Leidinger.net/test/ctf3.diff > : > : My commit log would be something like this: > : ---snip--- > : WITH_CTF can now be specified in src.conf (not recommended, there > : are some problems with static executables), make.conf (would also > : affect ports which do not use GNU make and do not override the > : compile targets) or in the kernel config (via "makeoptions > : WITH_CTF=yes"). > : > : Additional (related) changes: > : - propagate WITH_CTF to module builds > : - do not add -g to the linker flags, it's a noop there anyway > : (at least according to the man page of ld) > : - do not add -g yo CFLAGS unconditionally > : we need to have a look if it is really needed (IMO not) or if there > : is a way to add it only when WITH_CTF is used > : > : Note: don't worry when you see ctfconvert lines appearing in your > : build, > : they are protected with a shell conditional and are not run as long as > : you don't have WITH_CTF defined. > : > : Reviewed by: imp, jhb, scottl (earlier version) > : Discussed on: arch@ > : ---snip--- > : > : If nobody comes up with problems (or wants more time for the review): > : I would like to commit this next week. > > I agree with John about the @ sign. > > I'm a little worried about the WITH_CTF being special, but not > documented as being special. Can you add a note to bsd.own.mk > documenting it as such? > > Also, can you document WITH_CTF in build.9 please? I know that > build.9 needs some updating, but we should at least try to keep up > with new things. Many are missing now. This would also be a good > place to mention WITH_CTF is special. I will have a look at it next week. As I'm not a native english speaker, you can expect another patch for review (text suggestions for build.9 are welcome, I will take care about the mdoc markup then). Bye, Alexander. -- Multiple-function gadgets will not perform any function adequately. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137