From owner-dev-commits-src-all@freebsd.org Fri Jan 8 21:11:57 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E5C394D6DF3 for ; Fri, 8 Jan 2021 21:11:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DCG4s5W6Kz3HCm for ; Fri, 8 Jan 2021 21:11:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72f.google.com with SMTP id v126so9737099qkd.11 for ; Fri, 08 Jan 2021 13:11:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZeBBHI892XNjzcUYk57KuxuZ02IGXQL9hnzlJBUYhD4=; b=l6UuT/BryyIXVafQKZbc8YZSKe888SJE4meaHqGYhvdy0jc6md+CQJ9//44rZxYJ8S yhkmFEb0+54kOOGVgLmpWoVBkCiToTWlhdr8c81o3NTH4yAY2tnpOPyxuTJJgH0zYt8T ECmaT1fwbE18aoc6J9wsEka/wt9FwrEZJc1bGa+f2KxSjdJPSNwOUjv8NKm+TsAnO/9f PlvsKgBVd9UPH0/OLbtDP8pWnyyMVV0lDsodgiMRJLP9dEZyLrSzL2yC9Pd2VStz87F0 fw8qgrmOipht4CsLTw3vb6Ny04PRMbCTm0lUymeg7NTPqZai/sQ3DcutH5qrNBFpW5sg 6xYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZeBBHI892XNjzcUYk57KuxuZ02IGXQL9hnzlJBUYhD4=; b=YuUbmqUc8k7cLwZXG3W6phvffkqV0iYdZL2h2V3iwD7pcIW+aOHjuyjIeBBeB4WNwq 8Wl4TgUCuBqcAC8mlIACIlkLIW3IXINzt0wj1/3ZNGyPVdGm/rWwLnYHpALzQB6O0nVr ZkFL0VkIBtYFswLV+fY0uKdTcNK6/8G19a271BMF8Im93f9dXhpVxCgkXU6TKpqlEh5g SJ9TixxFb3dedq5It9l64TPiPJJFxWXYdwVZhWAXBbRSjVaEULEbaE6a9dq0l+BkTE2t L3OW5O7XnB+jwdjmZvGGYXLEfAqExKtBHMY/UpE+ETs4PAskZD2SAdMw6vkDvPj1eC/i xPSg== X-Gm-Message-State: AOAM5335Y6iMusGXb3XdO1QjdkdpQWt1V1PjBFNYInRjKEFx3WuC8k8E dUlBFkYDaVsYWY6ldPNuUuuEHPqieqpz4//mQYR5EA== X-Google-Smtp-Source: ABdhPJxX538toa6CHpGSlQF98+Wx/3fk1A/ZXyFeK7pSHObM5MmuVF89iGlQth5KimPyvUKadtZoKzXdb2d8PwxccJA= X-Received: by 2002:a37:4a4e:: with SMTP id x75mr5865575qka.89.1610140316849; Fri, 08 Jan 2021 13:11:56 -0800 (PST) MIME-Version: 1.0 References: <202101072320.107NKpMS063374@gitrepo.freebsd.org> <7a7fa0fb-51c2-1b14-6d37-2c400f69d7dd@kondratyev.su> <3EA011C9-2EEC-4693-B36D-69E74DF8473C@panasas.com> <20210108092638.x2kkvpeftey2wk62@ivaldir.net> In-Reply-To: From: Warner Losh Date: Fri, 8 Jan 2021 14:11:46 -0700 Message-ID: Subject: Re: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern. To: Konstantin Belousov Cc: Kyle Evans , Baptiste Daroussin , Vladimir Kondratyev , Ravi Pokala , Jessica Clarke , Vladimir Kondratyev , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" X-Rspamd-Queue-Id: 4DCG4s5W6Kz3HCm X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Mailman-Approved-At: Sat, 09 Jan 2021 07:51:09 +0000 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 21:11:58 -0000 On Fri, Jan 8, 2021 at 1:58 PM Konstantin Belousov wrote: > On Fri, Jan 08, 2021 at 07:46:31AM -0600, Kyle Evans wrote: > > On Fri, Jan 8, 2021 at 3:27 AM Baptiste Daroussin > wrote: > > > > > > On Fri, Jan 08, 2021 at 02:49:31AM +0300, Vladimir Kondratyev wrote: > > > > On 08.01.2021 02:41, Ravi Pokala wrote: > > > > > -----Original Message----- > > > > > From: on behalf of Vladimir > Kondratyev > > > > > Date: 2021-01-07, Thursday at 15:33 > > > > > To: Jessica Clarke , Vladimir Kondratyev > > > > > > Cc: "src-committers@freebsd.org" , " > dev-commits-src-all@freebsd.org" , " > dev-commits-src-main@freebsd.org" > > > > > Subject: Re: git: 92cf602e3809 - main - Copy strcasestr.c from > libc to libkern. > > > > > > > > > > On 08.01.2021 02:27, Jessica Clarke wrote: > > > > > > On 7 Jan 2021, at 23:20, Vladimir Kondratyev > wrote: > > > > > >> +#include > > > > > >> +#include > > > > > >> +#include "xlocale_private.h" > > > > > >> + > > > > > >> +/* > > > > > >> + * Find the first occurrence of find in s, ignore case. > > > > > >> + */ > > > > > >> +char * > > > > > >> +strcasestr_l(const char *s, const char *find, locale_t > locale) > > > > > > > > > > > > Locales in the kernel? This feels wrong. > > > > > > > > > > > > Jess > > > > > > > > > > > > > > > > strcasestr.c was copied from userland unmodified just to allow > > > > > "git log --follow" to work. Next commit removed locale support > from this > > > > > file and connected it to build. > > > > > > > > > > Unfortunately, about two-dozen commit messages from you arrived at > the same time, and some were out of order; without incrementing change > numbers in the subject line, figuring out the actual ordering is > non-trivial. :-p > > > > > > > > > > -Ravi (rpokala@) > > > > > > > > > > > > > I hope, commit hook will be improved some day. Pushing of two-dozen > > > > commits one by one is too boring. > > > > > > The history is in the right order and gitlog/cgit/anything that reads > the log > > > show everything in the right order. > > > > > > mails are asynchronuous, expecting the mail to always arrive in a > given order is > > > wrong ;) > > > > > > pushing all those commits at once was imho the right thing to do. > > > > > > > I've pointed this out a couple of times (with seemingly nothing coming > > from it), but the mails are being sent in reverse order. Fixing that > > would at least increase chances for some to receive them in order (and > > the archives show them perfectly in reverse order most of the time). > > > > Picking out the message-ids from the last series I sent, this is the > > correct order: > > > > 202101072237.107MbYaX002789@gitrepo.freebsd.org ("4832d2e8ae1d - main > > - du: tests: fix the H_flag test (primarily grep usage)") > > 202101072237.107MbYsM002771@gitrepo.freebsd.org ("3c5c39c7ad8f - main > > - du: tests: make H_flag tests more strict about output requirements") > > > > 202101072237.107MbYaX002789 -> 2789 was the last pid that assigned a > message-id > > 202101072237.107MbYsM002771 -> 2771 was the last pid that assigned a > message-id > > > > Given that this is clearly with kern.randompid=0 on the server, one > > can conclude that these were sent in the reverse order based on the > > pid sequence. If you pick a couple other series out, this holds true > > (at least for all the series I've looked at) > > Might be instead of trying to establish ordering by date, sending machinery > could set followup/in-reply-to headers to thread the whole batch. > Basically > emulate the 'git send-email' behavior. > > Then we can argue that only related patches should be committed in one > push, but practically that matches common workflow of developing on > topic branches and pushing them in one go. > it is guaranteed > I believe that https://github.com/git-multimail/git-multimail is being considered. It does what you suggest (or something similar). I'm not sure how well supported it is (it was written years ago, but has had some recent commits), or how well it meets our needs, but in the long run we'll need to do something like this. Warner