From owner-svn-src-user@freebsd.org Sat Mar 24 05:03:21 2018 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 29934F6CFBC for ; Sat, 24 Mar 2018 05:03:21 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail106.syd.optusnet.com.au (mail106.syd.optusnet.com.au [211.29.132.42]) by mx1.freebsd.org (Postfix) with ESMTP id 986307917F; Sat, 24 Mar 2018 05:03:20 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au [110.21.101.228]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id 721963CE1C3; Sat, 24 Mar 2018 16:03:12 +1100 (AEDT) Date: Sat, 24 Mar 2018 16:03:11 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: rgrimes@freebsd.org cc: Mark Johnston , src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r331461 - in user/markj/netdump/sys: kern netinet/netdump sys vm In-Reply-To: <201803240246.w2O2kZnB033985@pdx.rh.CN85.dnsmgr.net> Message-ID: <20180324153246.V927@besplex.bde.org> References: <201803240246.w2O2kZnB033985@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=cIaQihWN c=1 sm=1 tr=0 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17 a=kj9zAlcOel0A:10 a=6I5d2MoRAAAA:8 a=jMaHQTbOpqZ4ez4n5noA:9 a=Ok1cWiPjZdWjS-xC:21 a=aDCuVsFeLmuTuUg1:21 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Mar 2018 05:03:21 -0000 On Fri, 23 Mar 2018, Rodney W. Grimes wrote: >> Author: markj >> Date: Fri Mar 23 20:29:34 2018 >> New Revision: 331461 >> URL: https://svnweb.freebsd.org/changeset/base/331461 >> >> Log: >> Address some but not all review feedback from cem. > > Please be detailed in what is changing, as the above > only tells us where it came from in a vague way as > no review number is even cited. > > I know this is on a private branch, but when/if it > is merged this becomes part of the main line. Also, don't use spinmanagementspeak like "address" and "issue", or or programmerspeak like "kill". Bruce